Uncomment events, depend on strongloop/node-tap #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this branch, npm test appears to pass, but it lies. Run `NOPATCH=events npm test`, and you will see lots of tests pass, run with the EE patches, and most of the tests only have a test count of 1, because they are just exiting abruptly with a status of 0 (tap thinks that's success).
|
@piscisaureus, I PRed this branch to you so you can work on EE on it :-) feel free to push to it, and even rebase it around if you want. I just wanted the EE-enabled branch off of master while its being developed. Also, you can see I "fixed" the node-tap source, but what I did was not sufficient to get the tests passing (well, really passing). |
I'm probably missing context but isn't that a bug in the tests rather than the test runner? Are the tests calling process.exit()? That's almost always a testing anti-pattern, the event loop should die off naturally. |
This is needed because the duplex stream constructor calls EventEmitter() twice.
For more clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this branch, npm test appears to pass, but it lies. Run
NOPATCH=events npm test, and you will see lots of tests pass,run with the EE patches, and most of the tests only have a test count of
1, because they are just exiting abruptly with a status of 0 (tap thinks
that's success).