Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict caused by the "exports" object #260

Open
rkyoku opened this issue Sep 21, 2016 · 3 comments
Open

Conflict caused by the "exports" object #260

rkyoku opened this issue Sep 21, 2016 · 3 comments

Comments

@rkyoku
Copy link

rkyoku commented Sep 21, 2016

Hi,

The "exports" object created by RetinaJS is causing a conflict with a third party UMD bundler, used (among others) by Tooltipster.

The UMD loader checks the existence of "exports", and asserts that if it exists, we are in a Node environment. Which is not the case.

Is it possible for RetinaJS not to create this variable?

@bartvollebregt
Copy link

I think I'm having the same issue while using an external plugin.
I'm using the bootstrap datetimepicker: https://eonasdan.github.io/bootstrap-datetimepicker/

It throws a module.exports not defined error which is probaply related to this.

@rounders
Copy link

Also causes an issue when using Handlebars (http://handlebarsjs.com). Because of the existence of the 'exports' object, Handlebars doesn't load properly. Looks like same reason as above, handlebars looks for existence of "exports" object and if it finds it, it assumes we are in a Node environment.

@nkals722
Copy link

FWIW, the issue seems to only effect the minified version. Also, if you do a search and replace for "exports" and change it to something like "retexports", then the minified version works again. Would be nice to have an official version with that fix released though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants