Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it another bug (except the exports)? #273

Closed
jacksonwj opened this issue Feb 7, 2017 · 0 comments
Closed

Is it another bug (except the exports)? #273

jacksonwj opened this issue Feb 7, 2017 · 0 comments

Comments

@jacksonwj
Copy link

jacksonwj commented Feb 7, 2017

Except the exports (not defined), I just found another bug(maybe) in function getImages(images) (line 193) in the source file(uncompressed).

It CANNOT collect any image tag. The condition if (!images) made an incorrect decision in this function.

Maybe it should be if (images) to determine the document object.

Is that right?

@jacksonwj jacksonwj changed the title Was it another bug (except the exports)? Is it another bug (except the exports)? Feb 7, 2017
@strues strues closed this as completed Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants