-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribution #38
Comments
I have expanded the readme with the necessary licenses and attributions are shown briefly in the app and in the desktop version in the footer. I do that because the devices have a very small screen. do you think that's enough? |
Solely map attribution is needed. You can additionally attribute OpenStreetMap in your repository's README.md but this is optional. You do not have to mention "OpenStreetMap is a trademark of the OpenStreetMap Foundation. o.map is not endorsed by or affiliated with the OpenStreetMap Foundation." in your LICENSE or Licenses section (this should be used for your repository's license, the section in your README can also be used for software licenses if there's any); this is already specified on the copyright page, which should be linked from mentioned map attribution. If any data from third-party apps are stored on the user's browser/device (client), you can tell people in your own privacy police / terms page if you have one (for OpenStreetMap, this shouldn't be the case). I do not see any changes to the website in the referenced commits, but do see attribution is hidden in the map menu and/or in the web console. I can't seem to open the menu on clicking the 'menu' button in the bottom center. I also only see "Leaflet" (only the leaflet attribution, not additional attribution) for a brief moment on Desktop (on Desktop you should show it forever, you should be able to code for mobile seperate though may take longer). As for the mobile attribution, if you asked On Desktop, it should really look more like this image on the copyright page -with the leaflet attribution kept of course-, as it's most important to display directly on the map where it can be immediately seen by anyone; The additional attribution in the menu is welcome ofc. |
the dumbphone for which the app is intended only has keys, which is why the browser version is only key only. with enter you get to the menue for the layers switch etc. attribution now stays visible at > 600px viewport. |
Minor suggestions:
Other minor suggestions:
|
Will the attribution fit on a 240x320 screen? |
Feel free to look at good attribution examples for inspiration (not saying they are perfect). |
I have now added the attributions and added links to the sources in the menu. the desktop is only a showcase for the kaiOs users to show the functionality of the app. there are far better websites such as: umap which i use myself to plan tracks. I realize that I was a bit lax about specifying the data sources, but I think it should be ok now. please install the app on a kaiOs device then you will see how tight the space on the device is and you have to make some compromises. |
Hey John,
I noticed the following;
Make sure you have proper attribution for all map layers;
For copyright, see https://www.openstreetmap.org/copyright for OpenStreetMap for example.
For license, see ex. CreativeCommons website. You can also use https://chooser-beta.creativecommons.org/ to get some basic text (to display elsewhere).
The text was updated successfully, but these errors were encountered: