Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The plugin does not work with latest flutter beta #6

Closed
Sh1d0w opened this issue Sep 21, 2018 · 8 comments
Closed

The plugin does not work with latest flutter beta #6

Sh1d0w opened this issue Sep 21, 2018 · 8 comments

Comments

@Sh1d0w
Copy link

Sh1d0w commented Sep 21, 2018

Multiple errors are thrown if you use the plugin with the latest flutter beta.

@aqwert
Copy link
Collaborator

aqwert commented Sep 21, 2018

Can you post what error you are getting. I got the latest and it does compile for me. Is this iOS or Android. If iOS did you upgrade to the latest xcode?

@Sh1d0w
Copy link
Author

Sh1d0w commented Sep 21, 2018

Hi, yes it is iOS. The latest beta has some changes to the CupertinoNavigation widget which trows errors because tag property is not passed. Also I get some errors with PlatformScaffold.

@Sh1d0w
Copy link
Author

Sh1d0w commented Sep 21, 2018

See this for example:

https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/cupertino/nav_bar.dart#L192

Probably there are errors with other iOS widgets, as they were all updated in the latest beta, but I did not had a chance to test them all.

@aqwert
Copy link
Collaborator

aqwert commented Sep 21, 2018

Can you post the actual error you get. The hero tag has a default value so should not raise an error

I can see that I can expose more access the constructor arguments but this should not give errors

@Sh1d0w
Copy link
Author

Sh1d0w commented Sep 21, 2018

I/flutter (17873): ══╡ EXCEPTION CAUGHT BY SCHEDULER LIBRARY ╞═════════════════════════════════════════════════════════
I/flutter (17873): The following assertion was thrown during a scheduler callback:
I/flutter (17873): There are multiple heroes that share the same tag within a subtree.
I/flutter (17873): Within each subtree for which heroes are to be animated (typically a PageRoute subtree), each Hero
I/flutter (17873): must have a unique non-null tag.
In this case, multiple heroes had the following tag: Default Hero tag for Cupertino navigation bars

@aqwert
Copy link
Collaborator

aqwert commented Sep 21, 2018

Do you have a working sample that I could look at? Could be an issue with flutter itself and/or the way the cupertino widgets are being used

@Sh1d0w
Copy link
Author

Sh1d0w commented Sep 21, 2018

@aqwert Unfortunately it is a private project I am working on and it is not possible. I will try to to setup a sample repo to reproduce and will let you know. Thanks for your quick responses.

@aqwert
Copy link
Collaborator

aqwert commented Oct 14, 2018

I am closing this issue since it has been a while and I am unable to reproduce it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants