Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(diff): add new "diff" feature to mutant view #1515

Merged
merged 66 commits into from
Nov 19, 2021
Merged

feat(diff): add new "diff" feature to mutant view #1515

merged 66 commits into from
Nov 19, 2021

Conversation

nicojs
Copy link
Member

@nicojs nicojs commented Nov 11, 2021 •
edited

old new
image image

This adds the new "diff" feature to the mutant view. It also updated the test view to be in line with this way of working. The big changes:

  1. New "diff" view when selecting a mutant. Still shown inline, but now with a clear "git diff" like feature, including +/- and background-color
    image
  2. Since background color is used in the diff, we could no longer use that to mark mutants with a background color, instead using underline,
    image
  3. To not interrupt the new diff view, we decided to move the markers of mutants to the end of the line. We also decided to change the look to be a "dot".
    image
  4. Remove this underline when the mutant state is filtered out to form a calmer whole.
    image
  5. Since we can only show 1 diff at a time, we no longer support the "expand all" feature. Instead, we've introduced "next" and "previous" buttons at the top. This makes it easy to find the next surviving mutant, which closes Feature request: Survived mutant stepper #406.
  6. Quality of life: it is also possible to click directly on the code when a mutant is underlined there. Clicking multiple times will allow you to "browse" through the mutants active at the cursor.

In action:

inline-diff-demo-10

Closes #1419

nicojs and others added 30 commits October 24, 2021 22:45
@nicojs
WIP: experiment with diff view
24d5325
@simondel
Add lit-html to workspace
e377e8d
@simondel
Only show one mutant at a time
6f5fe24
@simondel
Implement custom line numbers
5aa0e7a
@nicojs
Merge branch 'master' into feat/new-diff
c16f6c1
@nicojs
mark mutants _after_ hightlight
8207496
@simondel
Use table for displaying code
2409670
@nicojs
Add mark mutants with parser
56c1274
@nicojs
Merge branch 'feat/new-diff' of github.com:stryker-mutator/mutation-t…
c48ddde 
…esting-elements into feat/new-diff
@nicojs
Fix merge conflicts
ba7f552
@nicojs
Focus diff
3cfc0d5
@nicojs
Use code table for tests as well
302ec85
@nicojs
Support spans in spans for highlighed html
0d673da
@nicojs
Merge branch 'master' into feat/new-diff
ae88f40
@nicojs
Improve code readeability
cfa6968
@nicojs
New diff with dots
716d847
@nicojs
Fix wavy
a85186e
@nicojs
Finalize look and feel diff view
8cbbc62
@nicojs
Implement unit tests for code-helpers and test-file
6198c80
@nicojs
Merge branch 'master' into feat/new-diff
e10936d
@nicojs
Remove 'mutation-test-report' prefix from test files
35642be
@nicojs
test(unit): add more file.component tests
f43c44f
@nicojs
Add more unit tests
323a65c
@nicojs
Improve test stability
a370d1c
@nicojs
Refactor state filter to raise the array if selected states in its ev…
d90eb87 
…ent detail
@nicojs
Add more tests
f9807a5
@nicojs
Remove only
c7d610d
@nicojs
Add more tests for test and mutant file
2b78365
@nicojs
Also highlight unknown languages
652da39
@nicojs
Refactor selectedMutantId -> selectedMutant
3cb660c
@nicojs
Copy link
Member Author

nicojs commented Nov 18, 2021

Green 💚🍏

@nicojs
Copy link
Member Author

nicojs commented Nov 19, 2021

@maks-rafalko you might also be interested in this

@hugo-vrijswijk hugo-vrijswijk merged commit c5f0657 into master Nov 19, 2021
@hugo-vrijswijk hugo-vrijswijk deleted the feat/new-diff branch November 19, 2021 11:06
@maks-rafalko
Copy link

This is very cool. I'm going to continue working on integration in infection/infection#1149, already prioritized for Infection.

Thank you for working on this!

@nicojs nicojs mentioned this pull request Dec 8, 2021
Closed
maks-rafalko added a commit to maks-rafalko/stryker-dashboard that referenced this pull request Dec 27, 2021
@maks-rafalko
Upgrade Stryker Dashboard to the latest Mutation Test Elements (1.7.8)
1466728 
Reasons:

* https://github.com/stryker-mutator/mutation-testing-elements/releases/tag/v1.7.7. There was a significant performance improvement. Current version is barely usable for Infection report, see https://dashboard.stryker-mutator.io/reports/github.com/infection/infection/master
* inline diff feature stryker-mutator/mutation-testing-elements#1515
@maks-rafalko maks-rafalko mentioned this pull request Dec 27, 2021
Merged
nicojs added a commit to stryker-mutator/stryker-dashboard that referenced this pull request Dec 31, 2021
@maks-rafalko @nicojs
feat(mutation testing elements): Update to 1.7.8 (#211)
0203930 
Reasons:

* https://github.com/stryker-mutator/mutation-testing-elements/releases/tag/v1.7.7. There was a significant performance improvement. Current version is barely usable for Infection report, see https://dashboard.stryker-mutator.io/reports/github.com/infection/infection/master
* inline diff feature stryker-mutator/mutation-testing-elements#1515

Co-authored-by: Nico Jansen <jansennico@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugo-vrijswijk hugo-vrijswijk hugo-vrijswijk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve "diff" view Feature request: Survived mutant stepper
4 participants
@nicojs @maks-rafalko @hugo-vrijswijk @simondel