New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(schema): Correctly validate schema version #2494
Conversation
metrics scala does not seem to accept the Pending state even though it was added here: Line 15 in 3780eb7
I also see that the schemaVersion is still Should that be updated to 2 @hugo-vrijswijk? |
It looks like it wasn't fully added to the JSON codec here, I can't add it today, but feel free to add it: https://github.com/stryker-mutator/mutation-testing-elements/blob/master/packages/metrics-scala/circe/src/main/scala/mutationtesting/circe.scala#L110
Yes, though it's a default property so can be overridden if needed |
I have no clue why the integration tests are failing.. See: #2495 |
Avoid platform differences in whitespace in colour properties by trimming the actual value before comparison. |
fix #2493
fix #2495
@nicojs Is this how we want to deal with this breaking change? Since it's a forward breaking change accepting V1 and V2 schemas in the same schema should be fine right?
I don't understand how the e2e test for v2 schema I added didn't catch this in the dashboard...