Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elements-table): transition score colors #2503

Merged
merged 1 commit into from May 11, 2023

Conversation

hugo-vrijswijk
Copy link
Member

Looks nice with the real-time updates 馃槂

image

@nicojs
Copy link
Member

nicojs commented May 10, 2023

Do you have an example? I tried to run it locally with the "馃殌 Realtime reporting example" but couldn't see the difference.

@hugo-vrijswijk
Copy link
Member Author

Yeah the realtime reporting example always pushes 'Killed' mutants, so it's pretty difficult to see as it's just about always green. You can see it better when switching directories (and the same line in the table has a different colour)

@xandervedder
Copy link
Contributor

xandervedder commented May 10, 2023

Do you have an example? I tried to run it locally with the "馃殌 Realtime reporting example" but couldn't see the difference.

It might be nice if the example sends a random status 馃

@hugo-vrijswijk
Copy link
Member Author

Do you have an example? I tried to run it locally with the "馃殌 Realtime reporting example" but couldn't see the difference.

It might be nice if the example sends a random status 馃

The issue is then that you approach a score of 50% 馃槂

@hugo-vrijswijk
Copy link
Member Author

hugo-vrijswijk commented May 10, 2023

I replayed the animation a couple times at a slowed down speed in devtools:

Screen.Recording.2023-05-10.at.12.49.36.mov

@rouke-broersma
Copy link
Member

Looks nice!

@rouke-broersma rouke-broersma merged commit 973c5c1 into master May 11, 2023
11 checks passed
@rouke-broersma rouke-broersma deleted the transition-colors branch May 11, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants