Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): move metrics to it's own package #28

Merged
merged 4 commits into from
Apr 9, 2019
Merged

Conversation

nicojs
Copy link
Member

@nicojs nicojs commented Apr 6, 2019

Move the calculation of the metrics to it's own package.
This way we can reuse it in the console reporter and the
stryker dashboard.

Move the calculation of the metrics to it's own package.
This way we can reuse it in the console reporter and the
stryker dashboard.
@nicojs
Copy link
Member Author

nicojs commented Apr 6, 2019

Our integration tests are a thing of beauty 😎. I've got high confidence even when changing around a lot like in this PR.

@hugo-vrijswijk
Copy link
Member

If I understand correctly, the plan is to have multiple language implementations for mutation-testing-metrics (which I think is a great idea, to have some sort of standard). Shouldn't the npm package be under a subfolder in packages/mutation-testing-metrics? So a node, jvm, .net, etc folder?

@nicojs
Copy link
Member Author

nicojs commented Apr 8, 2019

We can add that once we want to create it, right? No need to have that now. The npm package content would remain the same.

@nicojs nicojs merged commit fc66b8b into master Apr 9, 2019
@nicojs nicojs deleted the feat/split-metrics branch April 9, 2019 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants