New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: overhaul build with vite & playwright #2825
Conversation
This improvement is freakin' amazing 馃ぉ! I haven't had time to look at it yet, but I will try to do it in a 1h train ride later today. |
fad8134
to
ae28d1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've looked through the code together. 馃 Some findings:
- Vite is now responsible for bundling each project. Only elements should be bundled. We should use plain
tsc --build
like before. - It's OK to have a breaking change to move to
esm
. I didn't even realize this project was not ESM yet. - Dev experience:
- We should have an up-to-date CONTRIBUTING.md, including a cheat sheet.
- Some commands should work from the root. Useful ones might be:
test
andbuild
? - CTRL+SHIFT+B support and debugging (launch.json) should be updated
3c85cf1
to
5038a5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a lot better :). Just a few remarks:
- The task "Debug Unit Tests (elements)" is not working. How do we debug elements unit tests?
- The breaking change of not exporting
MutantStatus
anymore will hurt a bit in StrykerJS, as we use it all over the place (it was the only way to work with the mutant result). But I see why it is necessary. - How does one debug the playwright tests? I see the playwright plugin is added to the recommended plugins, can I use that? Maybe we can add this to the CONTRIBUTING.md?
I've updated the schema2ts script, so pull before changing anything else.
252de1a
to
b721dc4
Compare
BREAKING CHANGE: mutation-testing-report-schema and mutation-testing-metrics are now ESM BREAKING CHANGE: report-schema `MutantStatus` is a union type instead of TS enum
Overhauls the build (and tests) by setting up Vite to build all projects, and playwright for the elements integration tests.
BREAKING CHANGE: mutation-testing-report-schema and mutation-testing-metrics are now ESM
BREAKING CHANGE: report-schema
MutantStatus
is a union type instead of TS enum