Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Accept hidden config file. #3457

Merged
merged 1 commit into from Mar 7, 2022
Merged

feat: Accept hidden config file. #3457

merged 1 commit into from Mar 7, 2022

Conversation

regseb
Copy link
Contributor

@regseb regseb commented Mar 5, 2022

Accept hidden files (starting with a dot) for configuration. Configuration files are often hidden files (such as .mocharc.js or .eslintrc.js).

With this pull request, the stryker.conf.(json|js|mjs|cjs) and .stryker.conf.(json|js|mjs|cjs) files are searched by default.

@nicojs
Copy link
Member

nicojs commented Mar 6, 2022

Thanks for the PR.

Out of curiosity, what is the reason you would want your config in hidden files?

@regseb
Copy link
Contributor Author

regseb commented Mar 6, 2022

When a new contributor joins the project, it's very often to fix a bug or to add a feature. It's rarely to modify the tooling (lint, test, build or release). By hiding the configuration files (.git, .github, .editorconfig, .eslintrc.js, .gitignore, .mocharc.js, ...), the contributor sees only the files directly related to the program.

@nicojs
Copy link
Member

nicojs commented Mar 6, 2022

Ah, is that the reason? Kind of makes sense, maybe. I always configure hidden files to be visible, so I wondered why.

Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Please also add unit and integration tests to the core package. And the docs directory contains the docs for the website; please add an explanation about this feature to the config-file.md there.

@regseb
Copy link
Contributor Author

regseb commented Mar 6, 2022

@nicojs I added unit tests and a description in the documentation.

@nicojs nicojs merged commit 701374f into stryker-mutator:epic/esm Mar 7, 2022
@nicojs
Copy link
Member

nicojs commented Mar 7, 2022

Thanks @regseb

Would you mind also opening a PR here: https://github.com/vscode-icons/vscode-icons/

Since I just got the PR merged for stryker.conf.x files 😅

@regseb
Copy link
Contributor Author

regseb commented Mar 7, 2022

Pull request created: vscode-icons/vscode-icons#2951

@regseb regseb deleted the hidden branch March 7, 2022 13:46
@nicojs
Copy link
Member

nicojs commented Mar 7, 2022

Thanks a lot! 👍

Feel free to scout around for other issues you want to fix 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants