-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Accept hidden config file. #3457
Conversation
Thanks for the PR. Out of curiosity, what is the reason you would want your config in hidden files? |
When a new contributor joins the project, it's very often to fix a bug or to add a feature. It's rarely to modify the tooling (lint, test, build or release). By hiding the configuration files (.git, .github, .editorconfig, .eslintrc.js, .gitignore, .mocharc.js, ...), the contributor sees only the files directly related to the program. |
Ah, is that the reason? Kind of makes sense, maybe. I always configure hidden files to be visible, so I wondered why. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Please also add unit and integration tests to the core
package. And the docs
directory contains the docs for the website; please add an explanation about this feature to the config-file.md
there.
@nicojs I added unit tests and a description in the documentation. |
Thanks @regseb Would you mind also opening a PR here: https://github.com/vscode-icons/vscode-icons/ Since I just got the PR merged for |
Pull request created: vscode-icons/vscode-icons#2951 |
Thanks a lot! 👍 Feel free to scout around for other issues you want to fix 😁 |
Accept hidden files (starting with a dot) for configuration. Configuration files are often hidden files (such as .mocharc.js or .eslintrc.js).
With this pull request, the
stryker.conf.(json|js|mjs|cjs)
and.stryker.conf.(json|js|mjs|cjs)
files are searched by default.