Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to show emojis in console #3820

Merged
merged 14 commits into from
Oct 30, 2022
Merged

Add option to show emojis in console #3820

merged 14 commits into from
Oct 30, 2022

Conversation

brdv
Copy link
Contributor

@brdv brdv commented Oct 29, 2022 •
edited

Resolves #1189

  • Add (optional) emojis to clear-text output.
  • Added option 'enableConsoleEmojis' to show emojis

nicojs
nicojs reviewed Oct 29, 2022
View reviewed changes
packages/core/package.json Outdated Show resolved Hide resolved
@brdv brdv changed the title Add emojis by default to clear-text-report Add option to show emojis in console Oct 29, 2022
nicojs
nicojs requested changes Oct 29, 2022
View reviewed changes
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard work is paying off 💪. I've got some small remarks. Would you mind changing it?

packages/api/schema/stryker-core.json Outdated Show resolved Hide resolved
packages/api/schema/stryker-core.json Outdated Show resolved Hide resolved
packages/core/src/reporters/clear-text-reporter.ts Outdated Show resolved Hide resolved
packages/core/src/utils/string-utils.ts Outdated Show resolved Hide resolved
packages/core/src/stryker-cli.ts Outdated Show resolved Hide resolved
@brdv brdv requested a review from nicojs October 30, 2022 09:18
nicojs
nicojs approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This is a dlighted new feature that I hope we can enable by default in the future. 😍

@nicojs nicojs merged commit 79cc05f into stryker-mutator:master Oct 30, 2022
@nicojs
Copy link
Member

nicojs commented Oct 30, 2022

Released in 6.3.0 🎉

If you want you can also create a PR to document these console reporter options, they seem to be missing from https://stryker-mutator.io/docs/stryker-js/configuration/

@nicojs
Copy link
Member

nicojs commented Oct 30, 2022

See #3827

@nicojs nicojs mentioned this pull request Nov 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicojs nicojs nicojs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unicode emoji support in the console reporter
2 participants
@brdv @nicojs