Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use configuration values to ignorePatterns. #3894

Merged
merged 4 commits into from
Dec 25, 2022
Merged

fix: Use configuration values to ignorePatterns. #3894

merged 4 commits into from
Dec 25, 2022

Conversation

regseb
Copy link
Contributor

@regseb regseb commented Dec 6, 2022

Fix #3872

  • Replace "/reports" by incrementalFiles in ignorePatterns (tempDirName was already in use).
  • Describe tempDirName and incrementalFiles in documentation.

I didn't add htmlReporter.fileName and jsonReporter.fileName because I don't have access to these variables in the constructor.

Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this one up, and sorry it took me so long to respond. You should be able to add the output files from the HTML and JSON reporter quite easily; see my remark.

packages/core/src/fs/project-reader.ts Outdated Show resolved Hide resolved
packages/core/src/fs/project-reader.ts Outdated Show resolved Hide resolved
@regseb regseb requested a review from nicojs December 20, 2022 09:18
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I love the additional test and changes there.

@nicojs nicojs merged commit 2ff2f07 into stryker-mutator:master Dec 25, 2022
@regseb regseb deleted the ignorePatterns branch December 25, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use configuration values to the patterns that are always ignored (ignorePatterns)
2 participants