Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modern-init): Add create-stryker package #4644

Merged
merged 12 commits into from Jan 29, 2024

Conversation

lex-funy
Copy link
Contributor

@lex-funy lex-funy commented Dec 7, 2023

This pull request adds the stryker-initializer-lex package to the project, which is an initializer for StrykerJS. It includes the necessary dependencies and configuration files.

Fixes #4641

@lex-funy lex-funy changed the title Add stryker-initializer-lex package feat(modern-init): Add create-stryker package Dec 7, 2023
@nicojs
Copy link
Member

nicojs commented Dec 8, 2023

Thanks for opening this issue! I've linked #4641.

I had a discussion with @odinvanderlinden about this. We should move the entire initialization logic to this new package in the future. But that would be a breaking change (npx stryker init would no longer work).

packages/initializer/package.json Outdated Show resolved Hide resolved
@nicojs
Copy link
Member

nicojs commented Dec 8, 2023

Another question: do you want to update docs/getting-started.md in this PR or another one? Or do you want to leave that to someone else?

@lex-funy
Copy link
Contributor Author

lex-funy commented Dec 8, 2023

Another question: do you want to update docs/getting-started.md in this PR or another one? Or do you want to leave that to someone else?

I updated docs/getting-started.md, please let me know if it's ok.

@lex-funy lex-funy marked this pull request as ready for review December 8, 2023 17:25
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipeline is failing. Also some small remarks.

Thanks for updating the docs ❤️

packages/initializer/README.md Outdated Show resolved Hide resolved
packages/initializer/package.json Outdated Show resolved Hide resolved
workspace.code-workspace Outdated Show resolved Hide resolved
@nicojs nicojs enabled auto-merge (squash) January 29, 2024 10:03
@nicojs nicojs merged commit dc103cf into stryker-mutator:master Jan 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More modern way of initializing StrykerJS on a project
2 participants