-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick start generator doesn't seem to work for karma + mocha #29
Comments
Nice find! I'll fix it |
This won't work. The problem is that the I've opened an issue there with a long history: mochajs/mocha#2605 Basically we're at a dead end. The way mocha is set up prevents it from easily filtering tests during runtime. If it is added, it is most likely added in the test runner part of mocha and not in the test framework part. This is important because we've designed our interfaces and apis around a fact that the TestFramework is responsible for the filtering of the tests. If you have some time, please read through that issue, see if you can think of a way around this issue. Otherwise maybe its an idea to fork their repo and just add filtering of individual tests the way we want to. |
Karma runner + mocha framework does actually work for me (though presumably without filtering tests): http://github.com/COzero/nvd3/blob/2c62c1e28e7df00bcbaebfbb0d93ead8827f30a5/stryker.conf.js#L13 It did have this regrettable side effect but that was probably my fault for being too aggressive with concurrent runners: |
This has been fixed and it works using the stryker cli :) |
Maybe I'm doing something wrong but these instructions don't seem to work:
![image](https://cloud.githubusercontent.com/assets/1034890/23932449/2a6e2578-098c-11e7-9ac9-0bbf52438493.png)
Output:
It seems to work with mocha-runner installed. The quick start instructions should probably include stryker-mocha-runner as well as stryker-karma-runner.
I'd say this line is responsible: https://github.com/stryker-mutator/stryker-mutator.github.io/blob/master/javascripts/main.js#L50
The text was updated successfully, but these errors were encountered: