fix(broadcast-reporter): log error detail (#1461)

stryker-mutator · Mar 21, 2019 · 2331847 · 2331847
1 parent 588f832
commit 2331847
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/packages/core/src/reporters/BroadcastReporter.ts b/packages/core/src/reporters/BroadcastReporter.ts
@@ -100,6 +100,6 @@ export default class BroadcastReporter implements StrictReporter {
   }
 
   private handleError(error: Error, methodName: string, reporterName: string) {
-    this.log.error(`An error occurred during '${methodName}' on reporter '${reporterName}'. Error is: ${error}`);
+    this.log.error(`An error occurred during '${methodName}' on reporter '${reporterName}'.`, error);
   }
 }
diff --git a/packages/core/test/unit/reporters/BroadcastReporter.spec.ts b/packages/core/test/unit/reporters/BroadcastReporter.spec.ts
@@ -105,24 +105,28 @@ describe('BroadcastReporter', () => {
       });
 
       describe('and one of the promises results in a rejection', () => {
+        let actualError: Error;
         beforeEach(() => {
-          wrapUpRejectFn('some error');
+          actualError = new Error('some error');
+          wrapUpRejectFn(actualError);
           wrapUpResolveFn2();
           return result;
         });
 
         it('should not result in a rejection', () => result);
 
         it('should log the error', () => {
-          expect(testInjector.logger.error).calledWith(`An error occurred during 'wrapUp' on reporter 'rep1'. Error is: some error`);
+          expect(testInjector.logger.error).calledWith(`An error occurred during 'wrapUp' on reporter 'rep1'.`, actualError);
         });
       });
     });
 
     describe('with one faulty reporter', () => {
+      let actualError: Error;
 
       beforeEach(() => {
-        ALL_REPORTER_EVENTS.forEach(eventName => rep1[eventName].throws('some error'));
+        actualError = new Error('some error');
+        ALL_REPORTER_EVENTS.forEach(eventName => rep1[eventName].throws(actualError));
       });
 
       it('should still broadcast to other reporters', () => {
@@ -132,7 +136,7 @@ describe('BroadcastReporter', () => {
       it('should log each error', () => {
         ALL_REPORTER_EVENTS.forEach(eventName => {
           (sut as any)[eventName]();
-          expect(testInjector.logger.error).to.have.been.calledWith(`An error occurred during '${eventName}' on reporter 'rep1'. Error is: some error`);
+          expect(testInjector.logger.error).to.have.been.calledWith(`An error occurred during '${eventName}' on reporter 'rep1'.`, actualError);
         });
       });