fix: edge cases, duplication, log output (#1720)

stryker-mutator · Sep 13, 2019 · 7f42d34 · 7f42d34
1 parent ee19f5a
commit 7f42d34
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/core/src/config/ConfigValidator.ts b/packages/core/src/config/ConfigValidator.ts
@@ -62,12 +62,12 @@ export default class ConfigValidator {
   }
 
   private validateThresholdValue(name: keyof MutationScoreThresholds, value: number | null) {
-    if (typeof value === 'number' && (value < 0 || value > 100)) {
+    if (typeof value === 'number' && (value < 0 || value > 100 || isNaN(value))) {
       this.invalidate(`Value "${value}" is invalid for \`thresholds.${name}\`. Expected a number between 0 and 100`);
     }
   }
 
-  private validateThresholdsValueExists(name: keyof MutationScoreThresholds, value: number | undefined) {
+  private validateThresholdsValueExists(name: keyof MutationScoreThresholds, value: any) {
     if (typeof value !== 'number') {
       this.invalidate(`Value "${value}" is invalid for \`thresholds.${name}\`. Expected a number between 0 and 100`);
     }
@@ -77,7 +77,7 @@ export default class ConfigValidator {
     const logLevel = this.options[logProperty];
     const VALID_LOG_LEVEL_VALUES = [LogLevel.Fatal, LogLevel.Error, LogLevel.Warning, LogLevel.Information, LogLevel.Debug, LogLevel.Trace, LogLevel.Off];
     if (VALID_LOG_LEVEL_VALUES.indexOf(logLevel) < 0) {
-      this.invalidate(`Value "${logLevel}" is invalid for \`logLevel\`. Expected one of the following: ${this.joinQuotedList(VALID_LOG_LEVEL_VALUES)}`);
+      this.invalidate(`Value "${logLevel}" is invalid for \`${logProperty}\`. Expected one of the following: ${this.joinQuotedList(VALID_LOG_LEVEL_VALUES)}`);
     }
   }