Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest config): set notify to false in JEST_OVERRIDE_OPTIONS #1419

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

ollelauribostrom
Copy link
Contributor

@ollelauribostrom ollelauribostrom commented Feb 25, 2019

I propose turning of jest notifications by default. Having test notifications turned on in a project can ofc be a great thing but when stryker runs the tests this adds a lot of noise (one notification each time stryker runs the tests against a mutant).

Summary of changes

  • Adding notify: false to jestOverrideOptions.ts
  • Updating tests to verify that this property is overridden

@ghost ghost added the 🔎 Needs review label Feb 25, 2019
@simondel
Copy link
Member

What does this look like without explicitly setting it to off?

And what does it look like with the setting explicitly set to off but Stryker's logging set to 'TRACE'?

@ollelauribostrom
Copy link
Contributor Author

ollelauribostrom commented Feb 26, 2019

Looks like this without explicitly turning this off:
https://media.giphy.com/media/8UGFvYxcwWWDrblA77/giphy.gif

Trace:
https://gist.github.com/ollelauribostrom/27f9e8dc8afd2c8abc3a1391cd0fd0ad
(Note that im running Stryker programatically from a custom script if that could have an impact on the trace 🙂)

@nicojs
Copy link
Member

nicojs commented Feb 27, 2019

Lol @ notifications :)

Turning it off sounds like the best approach.

@nicojs nicojs merged commit 948166b into stryker-mutator:master Feb 27, 2019
@ghost ghost removed the 🔎 Needs review label Feb 27, 2019
@simondel
Copy link
Member

Wow that's something you don't want to have enabled when doing mutation testing 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants