Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New html reporter should escape html characters in strings #1482

Closed
nicojs opened this issue Apr 3, 2019 · 2 comments
Closed

New html reporter should escape html characters in strings #1482

nicojs opened this issue Apr 3, 2019 · 2 comments
Assignees
@nicojs

Comments

@nicojs
Copy link
Member

nicojs commented Apr 3, 2019

The new HTML reporter should escape HTML strings. Right now, a </script> in the client's code results in an invalid HTML document, rendering the HTML report useless.
@nicojs nicojs mentioned this issue Apr 3, 2019
Closed
@ghost ghost assigned nicojs Apr 4, 2019
@ghost ghost added the 🛠 In progress label Apr 4, 2019
@nicojs nicojs mentioned this issue Apr 4, 2019
Merged
@nicojs
Copy link
Member Author

nicojs commented Apr 4, 2019

The report looks like this:

image

simondel pushed a commit that referenced this issue Apr 4, 2019
@nicojs @simondel
fix(html): load report json from a js file (#1485)
9bee2a7 
Support HTML fragments in user code by loading
it from a JS file, instead if inserting it inside a script
tag. Inserting in script tags resulted in errors when
user code contains `"</script>"` .

Fixes #1482
@ghost ghost removed the 🛠 In progress label Apr 4, 2019
@hugo-vrijswijk hugo-vrijswijk mentioned this issue Apr 4, 2019
Merged
@hugo-vrijswijk
Copy link
Member

We should also update the examples in the elements repo and explain why not to do this for new reports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicojs nicojs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicojs @hugo-vrijswijk