Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): load report json from a js file #1485

Merged
merged 3 commits into from
Apr 4, 2019

Conversation

nicojs
Copy link
Member

@nicojs nicojs commented Apr 4, 2019

Support HTML fragments in user code by loading
it from a JS file, instead if inserting it inside a script
tag. Inserting in script tags resulted in errors when
user code contains "</script>" .

Fixes #1482

Support HTML fragments in user code by loading
it from a JS file, instead if inserting it inside a script
tag. Inserting in script tags resulted in errors when
user code contains `"</script>"` .
@ghost ghost assigned nicojs Apr 4, 2019
@ghost ghost added the 🔎 Needs review label Apr 4, 2019
@simondel simondel merged commit 9bee2a7 into master Apr 4, 2019
@ghost ghost removed the 🔎 Needs review label Apr 4, 2019
@simondel simondel deleted the 1482-fix-html-reporter-closing-script-tag branch April 4, 2019 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants