Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: output es2017 code #1518

Merged
merged 6 commits into from
May 17, 2019
Merged

build: output es2017 code #1518

merged 6 commits into from
May 17, 2019

Conversation

simondel
Copy link
Member

No description provided.

@nicojs
Copy link
Member

nicojs commented Apr 21, 2019

I think this PR changes too many tsconfig.json files. Should only be the once governing Stryker IMHO.

@bartekleon
Copy link
Member

bartekleon commented Apr 26, 2019

I don't know if it is good that you are removing Libs. I don't think ES2017 contains DOM lib etc. It should all be added as it was in my opinion.
I guess it can be compared to C++. You can use C++11, C++14, C++17 versions, but libs are still required so you can't just omit iostream for example only coz you switched C++ version from 11 to 17.

@nicojs
Copy link
Member

nicojs commented Apr 29, 2019

@kmdrGroch es2017 indeed doesn't include DOM, but it shouldn't as Stryker runs in NodeJS, right?

@simondel
Copy link
Member Author

I have removed the other tsconfig changes.

@bartekleon
Copy link
Member

@nicojs, @simondel change target to "target": "es2017" and just add to libs es2017. Do not remove older libs like es2015, etc

@bartekleon
Copy link
Member

bartekleon commented Apr 30, 2019

and @nicojs all these libs are nothing more as the sets of types / interfaces. It is the same as you are using @types/mocha for example. It is like using @types/ecmascript5, @types/DOM.

@nicojs
Copy link
Member

nicojs commented May 1, 2019

@kmdrGroch

change target to "target": "es2017" and just add to libs es2017. Do not remove older libs like es2015, etc

I'm pretty sure that es2017 includes 2015 etc. See https://github.com/Microsoft/TypeScript/blob/master/lib/lib.es2017.d.ts

and @nicojs all these libs are nothing more as the sets of types / interfaces. It is the same as you are using @types/mocha for example. It is like using @types/ecmascript5, @types/DOM.

I know. However, I don't want those types. For example, I don't want to accidentally add document.getElementById somewhere in our code.

@bartekleon
Copy link
Member

bartekleon commented May 2, 2019

yea, you are right. They have reflections to previous versions, my fault.

And I see from travis logs, there is problems with timeout :/ maybe try rerunning tests / increase timeout time

@nicojs nicojs added this to the 2.0 release milestone May 2, 2019
@nicojs
Copy link
Member

nicojs commented May 2, 2019

Yeah, we'll have 16th and 17th this month dedicated to Stryker development. We'll release Stryker 2.0 then.

@simondel simondel merged commit e85561e into master May 17, 2019
@simondel simondel deleted the ts-es2017 branch May 17, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants