-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: output es2017 code #1518
Conversation
I think this PR changes too many tsconfig.json files. Should only be the once governing Stryker IMHO. |
I don't know if it is good that you are removing Libs. I don't think ES2017 contains DOM lib etc. It should all be added as it was in my opinion. |
@kmdrGroch |
I have removed the other tsconfig changes. |
and @nicojs all these libs are nothing more as the sets of types / interfaces. It is the same as you are using @types/mocha for example. It is like using @types/ecmascript5, @types/DOM. |
@kmdrGroch
I'm pretty sure that
I know. However, I don't want those types. For example, I don't want to accidentally add |
yea, you are right. They have reflections to previous versions, my fault. And I see from travis logs, there is problems with timeout :/ maybe try rerunning tests / increase timeout time |
Yeah, we'll have 16th and 17th this month dedicated to Stryker development. We'll release Stryker 2.0 then. |
No description provided.