Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dispose): clean up child processes in alternative flows #1520

Merged
merged 4 commits into from
Apr 24, 2019
Merged

fix(dispose): clean up child processes in alternative flows #1520

merged 4 commits into from
Apr 24, 2019

Conversation

nicojs
Copy link
Member

@nicojs nicojs commented Apr 19, 2019 •
edited

Make sure Stryker doesn't hang indefinitely when it supposed to exit prematurely.
Before, there was a code path that didn't dispose all child processes.
Now using typed-injects dispose functionality.

  • Fix failing unit tests
  • Implement new unit test for te try...finally
  • Create an e2e test that hits the alternative flow with a transpiler, so we make sure this never happens again

Fixes #1519

@nicojs
fix(dispose): clean up child processes in alternative flows
b0f761e 
Make sure Stryker doesn't _hang indefinitely_ when it supposed to _exit prematurely_.
Before, there was a code path that didn't dispose all child processes.
Now using typed-injects [dispose functionality](https://github.com/nicojs/typed-inject/#-disposing-provided-stuff).
@nicojs nicojs mentioned this pull request Apr 19, 2019
Closed
@nicojs nicojs marked this pull request as ready for review April 21, 2019 09:18
@simondel simondel self-requested a review April 24, 2019 07:13
simondel
simondel approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@simondel simondel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nicojs nicojs merged commit 31ee085 into master Apr 24, 2019
@nicojs nicojs deleted the 1519-fix-stryker-hangs branch April 24, 2019 08:45
@nicojs nicojs mentioned this pull request Apr 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simondel simondel simondel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nicojs @simondel @sanderkoenders @richardwerkman