Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formatting): remove dependency on prettier #1552

Merged
merged 1 commit into from
May 17, 2019

Conversation

nicojs
Copy link
Member

@nicojs nicojs commented May 17, 2019

After stryker init was succesful, run prettier from the command line using npx prettier --write stryker.conf.js in order to format the resulting configuration file, rather than having prettier as a dependency directly.
Prettier became pretty expensive, sitting at 1.2 MB.

Fixes #1261

After `stryker init` was succesful, run prettier from the command line using `npx prettier --write stryker.conf.js` in order to format the resulting configuration file, rather than having prettier as a dependency directly.
Prettier became pretty expensive, sitting at 1.2 MB.

Fixes #1261
Copy link
Member

@simondel simondel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nicojs nicojs merged commit 24543d3 into master May 17, 2019
@nicojs nicojs deleted the feat/remove-dep-prettier branch May 17, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove prettier as a dependency
3 participants