Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option to provide babelPlugins #1764

Merged
merged 31 commits into from
Nov 5, 2019
Merged

feat: add option to provide babelPlugins #1764

merged 31 commits into from
Nov 5, 2019

Conversation

bartekleon
Copy link
Member

@bartekleon bartekleon commented Oct 5, 2019 •
edited
Loading

fixes: #1614
fixes: #1806

kmdrGroch and others added 18 commits July 7, 2019 02:45
@bartekleon
Copy link
Member Author

(i was hoping for github CI to remove all previous works ._.)

@bartekleon bartekleon mentioned this pull request Oct 28, 2019
Closed
nicojs
nicojs requested changes Oct 31, 2019
View reviewed changes
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR. I can see you can find your way around our code base now, great job!

I've got a few remarks, mostly about keeping the name of "babel" outside of the Stryker API. Would you mind taking a look?

packages/api/package.json Outdated Show resolved Hide resolved
packages/api/src/core/MutatorDescriptor.ts Outdated Show resolved Hide resolved
packages/core/src/di/factoryMethods.ts Show resolved Hide resolved
packages/javascript-mutator/src/JavaScriptMutator.ts Outdated Show resolved Hide resolved
packages/javascript-mutator/src/JavaScriptMutator.ts Outdated Show resolved Hide resolved
packages/test-helpers/src/TestInjector.ts Show resolved Hide resolved
nicojs
nicojs approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmdrGroch I've changed some things. Most importantly, I've made sure that people can override the plugins, instead of only expand them. Also did some small improvements:

  • Added the plugins override to the babel e2e test
  • Added validation for the mutator.plugins config option
  • Documented mutator.plugins in readme's (core and javascript-mutator)

I've you approve we can merge it.

@bartekleon
Copy link
Member Author

Cool, looks great, it even passes tests :D

@nicojs nicojs merged commit ddb3d60 into stryker-mutator:master Nov 5, 2019
@bartekleon bartekleon deleted the fix-#1614 branch November 5, 2019 14:28
@bartekleon bartekleon mentioned this pull request Nov 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicojs nicojs nicojs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bartekleon @nicojs