feat(Jest): support overriding config #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicojs
commented
May 13, 2020
| @@ -18,10 +19,7 @@ export default class ReactScriptsTSJestConfigLoader implements JestConfigLoader | |||
|
|
|||
| // Create the React configuration for Jest | |||
| const jestConfiguration = this.createJestConfig(reactScriptsTsLocation); | |||
|
|
|||
| // Set test environment to jsdom (otherwise Jest won't run) | |||
| jestConfiguration.testEnvironment = 'jsdom'; | |||
There was a problem hiding this comment.
@simondel this made the test succeed
There was a problem hiding this comment.
Well it turns out react-scripts does use 'jsdom' as a default (facebook/create-react-app#5074) but react-scripts-ts was forked before that change was made and it hasn't really been updated for two years...
simondel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jest.configFileto specify a path to your config file. This file will be loaded usingrequirejest.configsetting now works together withjest.configFileto allow you to override the config in yourconfigFileFixes #2155