Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mutators): add mutators to instrumenter package #2266

Merged
merged 10 commits into from Jun 19, 2020
Merged

feat(mutators): add mutators to instrumenter package #2266

merged 10 commits into from Jun 19, 2020

Conversation

simondel
Copy link
Member

Adds mutators:

  • ArithmeticOperator
  • ArrayDeclaration
  • ArrowFunction
  • BlockStatement
  • BooleanLiteral
  • ConditionalExpression
  • EqualityOperator
  • LogicalOperator
  • ObjectLiteral
  • StringLiteral
  • UnaryOperator
  • UpdateOperator

nicojs
nicojs requested changes Jun 18, 2020
View reviewed changes
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

A few remarks. In general, I see you're using types.isXXX() instead of path.isXXX(). Not wrong, just a little more verbose I guess.

Found one instance of a clone missing, rest can land as is.

packages/instrumenter/src/mutators/array-declaration-mutator.ts Outdated Show resolved Hide resolved
packages/instrumenter/src/mutators/block-statement-mutator.ts Show resolved Hide resolved
packages/instrumenter/src/mutators/unary-operator-mutator.ts Outdated Show resolved Hide resolved
packages/instrumenter/src/mutators/update-operator-mutator.ts Outdated Show resolved Hide resolved
@nicojs nicojs merged commit 3b87743 into epic/mutation-switching Jun 19, 2020
@nicojs nicojs deleted the feat/add-mutators branch June 19, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicojs nicojs nicojs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simondel @nicojs