Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ArrowFunction mutator): don't mutate () => undefined #2313

Merged
merged 2 commits into from Aug 3, 2020

Conversation

simondel
Copy link
Member

Fixes #2306

@bartekleon
Copy link
Member

It is so big if statement I would rather use normal "if/else" instead of ternary. It really reduces readability

@bartekleon
Copy link
Member

And could you also check if "() => void" is mutated?

@brodybits
Copy link

[...] ternary. It really reduces readability

I think there are 2 major causes:

This is really unfortunate, since I find ternaries to be much more too the point in general.

Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be cleanup a little, refactoring is welcome.

@nicojs nicojs merged commit 310145e into epic/mutation-switching Aug 3, 2020
@nicojs nicojs deleted the 2306-arrowfunction-undefined branch August 3, 2020 18:12
@rodoabad
Copy link

rodoabad commented Aug 3, 2020

Yahoo! Thanks, @nicojs !

@nicojs
Copy link
Member

nicojs commented Aug 3, 2020

Sure thing @rodoabad ! Just remember that this will be part of Stryker 4.0. I'm planning to release a new version of the beta later this week and we'll be working to a release this month or next month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArrowFunction mutation question
5 participants