Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GetDaxConn to Dax's method if type parameters are allowed in methods #59

Open
sttk opened this issue Aug 13, 2023 · 0 comments
Open
Assignees
Labels
on hold Put on hold and will deal with in the future

Comments

@sttk
Copy link
Owner

sttk commented Aug 13, 2023

Since golang does not allow type parameters on methods now, GetDaxConn[D DaxConn] is defined as a global function.
If the following proposal is adopted, I'll change GetDaxConn[D DaxConn] to Dax's method.

proposal: https://github.com/golang/go/issues/49085

Example:

    conn, err := sabi.GetDaxConn[MyDax](dax, "database");
        ↓
    conn, err := dax.GetDaxConn[MyDax]("database");
@sttk sttk added the on hold Put on hold and will deal with in the future label Aug 14, 2023
@sttk sttk self-assigned this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Put on hold and will deal with in the future
Projects
None yet
Development

No branches or pull requests

1 participant