Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Konosuba does not gets scrobled #4

Closed
justalemon opened this issue May 22, 2019 · 6 comments
Closed

Konosuba does not gets scrobled #4

justalemon opened this issue May 22, 2019 · 6 comments

Comments

@justalemon
Copy link

On S01E01, you get "TypeError: failed to fetch":

image

On S01E02, you get "Could not find matching episode on Trakt"

image

I feel that is related to the matching of Crunchyroll Names with Trakt Show Names, because the name on Crunchyroll is:

KONOSUBA -God's blessing on this wonderful world!

And on Trakt is:

KonoSuba: God's Blessing on This Wonderful World!
@justalemon
Copy link
Author

If the name is causing the problem, a fuzzy string searching might work by ignoring the casing and removing the special characters (like -, ' and !).

@sttz
Copy link
Owner

sttz commented May 28, 2019

Thanks for pointing this out!

This seems to be an issue with Trakt. Trakt has the exact title as an alias but for some reason the show does not appear in the search results. I've opened an issue on Trakt's api-help.

I would prefer not to mess with the title being looked up. The preferred way to resolve weird titles on Crunchyroll would be to add them as alternative titles on TMDB, which then gets picked up by Trakt. I hope Trakt is able to resolve this on their end.

@justalemon
Copy link
Author

justalemon commented Dec 23, 2019

The RegEx [\+\-&\|!\(\){}\[\]\^"~\*\?:\/] (example on RegExr) can be used for matching Solr special characters, with this is possible to get the characters and escape them correctly.

image

I don't know how RegEx works in JavaScript/TypeScript, so the sintaxis might be wrong or invalid.

@justalemon
Copy link
Author

Just did a quick check by adding a backslash before - and ! and it works:

image

The weird thing is, this is not automatically handled by the web page of Trakt.

@justalemon
Copy link
Author

The other solution would be quoting the title, as mentioned on trakt/api-help#76

@sttz
Copy link
Owner

sttz commented Dec 26, 2019

This has been fixed in 1.0.6.

There are still issues with e.g. S02E11, which gets mistaken for S02E01. But that's a separate issue (E01 has number_abs = 11) and doesn't have a simple fix.

@sttz sttz closed this as completed Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants