Skip to content
This repository has been archived by the owner on Mar 14, 2020. It is now read-only.

Review acceptance criteria #27

Open
mattbaumann opened this issue Jul 28, 2018 · 0 comments
Open

Review acceptance criteria #27

mattbaumann opened this issue Jul 28, 2018 · 0 comments
Assignees
@mattbaumann
Labels
enhancement New feature or request Small Small change
Projects
Codesprint FS2018

Comments

@mattbaumann
Copy link
Contributor

I propose to add a simple checklist to ensure consistent pull-request reviews.

I will add the following topics to the list with this commit:

  1. Do code-changes match issue-statement?
  2. Was Documentation properly updated to reflect the changes/additions?
@mattbaumann mattbaumann added enhancement New feature or request Small Small change labels Jul 28, 2018
@mattbaumann mattbaumann self-assigned this Jul 28, 2018
@mattbaumann mattbaumann added this to To do in Codesprint FS2018 via automation Jul 28, 2018
@mattbaumann mattbaumann mentioned this issue Jul 28, 2018
Closed
@mattbaumann mattbaumann moved this from To do to In progress in Codesprint FS2018 Jul 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mattbaumann mattbaumann

Labels
enhancement New feature or request Small Small change
Projects
Codesprint FS2018
  
In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create Review checklist studentenportal/deploy-new
1 participant
@mattbaumann