Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker is undefined if installing via npm and tracker not meteor added #6

Closed
saimeunt opened this issue Apr 7, 2016 · 11 comments
Closed

Comments

@saimeunt
Copy link

saimeunt commented Apr 7, 2016

To reproduce, meteor create a new project with 1.3, npm install this package and meteor remove tracker.
tracker is explicitly api.implied using the atmosphere package but there's no such thing using the npm version.
quickfix is to add back tracker as a top level dependency, maybe just clarifying this in the README is enough?

@timbrandin
Copy link
Member

Is there an npm version now? I heard they are working on one, until then we need the meteor package tracker as this is a Tracker package. There's a thread on moving Tracker to npm over here: https://forums.meteor.com/t/request-publish-tracker-on-npm/20571

@saimeunt
Copy link
Author

saimeunt commented Apr 8, 2016

Oh, I meant installing tracker-component via npm, not tracker itself.
Publishing tracker on npm would indeed solve this problem because your npm package could depend on it :)

@timbrandin
Copy link
Member

Exactly, and I don't think it's far off, noting that @tmeasday wrote:

I think it makes sense for Tracker to be the first package we get onto npm. Working on it.

@timbrandin
Copy link
Member

I've started working on Tracker here, just to get somewhere faster than MDG can:
http://github.com/studiointeract/tracker

@firrae
Copy link

firrae commented Apr 12, 2016

So then does the NPM version of tracker-component rely on your NPM version of Tracker?

@jshimko
Copy link

jshimko commented Apr 12, 2016

Not sure if this is related, but updating from 1.1.16 to 1.1.17 gives me this...

ReferenceError: Tracker is not defined
    at Object.<anonymous> (/Users/Jeremy/.meteor/packages/std_accounts-ui/.1.1.17.3u3am0++os+web.browser+web.cordova/npm/node_modules/tracker-component/dist/index.js:49:1)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/Users/Jeremy/.meteor/packages/std_accounts-ui/.1.1.17.3u3am0++os+web.browser+web.cordova/npm/node_modules/tracker-component/index.js:1:18)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
=> Exited with code: 8

Reverting back to any earlier version fixes it immediately.

@firrae
Copy link

firrae commented Apr 12, 2016

@jshimko that is the EXACT error I'm seeing.

@timbrandin
Copy link
Member

Yeah, we really need tracker on NPM now @zol

@timbrandin
Copy link
Member

I'll be working on this later today, adding back the check for Package['tracker'], even though I don't experience this myself.

@timbrandin
Copy link
Member

The latest version has a check for this, if you could try that out, it'd be awesome. I've just checked it with std:accounts-ui.

But if you encounter any issues, I know meteor has an issue with updating the isopacks dependencies, so if your still experiencing issues, just remove the package with the broken dependency in this folder: .meteor/local/isopacks.

Hope all goes well! 💃

@timbrandin
Copy link
Member

Closing due to no activity in +1 month here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants