Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

Testimonial block: Removing person's title doesn't work as expected #24

Closed
mindctrl opened this issue Nov 5, 2018 · 2 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@mindctrl
Copy link
Member

mindctrl commented Nov 5, 2018

This doesn't seem to happen every time, and I've been unable to reproduce reliably, but the gist of it is laid out below. I think it could be related to how weird it is to get back into the placeholder field/area once you've removed the title and poking around all the keys is causing something funky under the hood, but I could be way off base. Haven't dug into the code at all.

Removing the title results in the letter F or lowercase f being saved in the title.

Steps to reproduce:

  • Add Testimonial block
  • Add some text
  • Add a name
  • Add a title
  • Save page
  • Edit title and remove it
  • Save page

Visually it looks like it was removed, but viewing it on the front end shows an F where the title goes. Editing the page again in the admin will reveal the F. If you try to remove it and save, you'll see it again appears to be removed but on the front end it's still there and if you refresh the admin edit page you'll see it reappear.

Atomic Blocks: 1.3.6
Gutenberg: 4.1.1
WP: 4.9.8

@mindctrl mindctrl added the bug Something isn't working label Nov 5, 2018
@mindctrl
Copy link
Member Author

mindctrl commented Nov 5, 2018

Screenshot:
image

@mindctrl mindctrl modified the milestones: 1.3.7, 1.3.8 Nov 7, 2018
@mikemcalister
Copy link
Contributor

Fixed in 1.3.9.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants