Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

ab-container block fails validation after changing alignment #39

Closed
antpb opened this issue Dec 5, 2018 · 2 comments
Closed

ab-container block fails validation after changing alignment #39

antpb opened this issue Dec 5, 2018 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@antpb
Copy link

antpb commented Dec 5, 2018

Hi!

I noticed when playing around with the container block that changing alignment to not be centered causes a validation issue. If I find why, I can make a PR. :)

Using Version 1.4.2 . Here's the error:

Expected:

<div style="background-color:#fff;padding-left:5%;padding-right:5%;padding-bottom:20%;padding-top:20%;margin-top:0%;margin-bottom:0%" class="wp-block-atomic-blocks-ab-container alignundefined aligncenter ab-block-container"><div class="ab-container-inside"><div class="ab-container-image-wrap"><img class="ab-container-image has-background-dim-100 has-background-dim" src="http://antpb.staging.wpengine.com/wp-content/uploads/2018/06/Screenshot-2018-04-05-22.29.08.png" alt=""/></div><div class="ab-container-content" style="max-width:1600px"></div></div></div>

Actual:

<div style="background-color:#fff;padding-left:5%;padding-right:5%;padding-bottom:20%;padding-top:20%;margin-top:0%;margin-bottom:0%" class="wp-block-atomic-blocks-ab-container alignundefined ab-block-container"><div class="ab-container-inside"><div class="ab-container-image-wrap"><img class="ab-container-image has-background-dim-100 has-background-dim" src="http://antpb.staging.wpengine.com/wp-content/uploads/2018/06/Screenshot-2018-04-05-22.29.08.png" alt=""/></div><div class="ab-container-content" style="max-width:1600px"></div></div></div>
(anonymous) @ index.js?ver=1543977903:2
@mindctrl mindctrl added the bug Something isn't working label Jan 9, 2019
@mindctrl mindctrl added this to the 1.4.23 milestone Jan 9, 2019
@sarahannnicholson
Copy link

sarahannnicholson commented Feb 5, 2019

This happens in the Accordion block when adding any HTML as well

@mikemcalister
Copy link
Contributor

The alignment and background color issue has been fixed in 1.5.0! Thanks for the heads up!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants