Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import deck from git repository link #46

Closed
evolverine opened this issue Mar 29, 2019 · 3 comments
Closed

Import deck from git repository link #46

evolverine opened this issue Mar 29, 2019 · 3 comments
Labels
enhancement git history import

Comments

@evolverine
Copy link
Contributor

Instead of just downloading the repository, collaboration on decks requires cloning repositories, in order to have the original remote configured, so that people can push their changes to github.
@Stvad
Copy link
Owner

Stvad commented Apr 6, 2019

The original design was caused by the fact that there was no actual git integration present. Now with dulwich being one of the dependencies this should be fairly easy to implement.

Some requirements:

  • Clone into the snapshot directory
  • If repository already exists in snapshot directory
    • Do git remote add (if not present)
    • git pull <new remote> master

@Stvad Stvad changed the title Clone repository instead of downloading zip Import deck from git repository link Apr 6, 2019
@Stvad Stvad mentioned this issue Apr 6, 2019
Closed
@evolverine
Copy link
Contributor Author

working on this now, should have a pull request ready in a couple of days.

@Stvad
Copy link
Owner

Stvad commented Mar 21, 2020

nice! Thank you!

evolverine added a commit to evolverine/CrowdAnki that referenced this issue Mar 25, 2020
@evolverine
Stvad#46 adding GitPython source, including its dependencies
85fb7e2
evolverine added a commit to evolverine/CrowdAnki that referenced this issue Mar 25, 2020
@evolverine
Stvad#46 added the basic functionality to create and update a reposit…
b5a5f67 
…ory by default instead of downloading the repository zip file
evolverine added a commit to evolverine/CrowdAnki that referenced this issue Mar 25, 2020
@evolverine
Stvad#46 marking the extra line of code that probably needs to be kep…
09d04f2 
…t in place in future GitPython updates for the imports to work
evolverine added a commit to evolverine/CrowdAnki that referenced this issue Mar 25, 2020
@evolverine
Stvad#46 removing tests from GitPython sources and its dependencies
d416e9f
evolverine added a commit to evolverine/CrowdAnki that referenced this issue Mar 25, 2020
@evolverine
Stvad#46 using Dulwich to clone and pull
94694a7
evolverine added a commit to evolverine/CrowdAnki that referenced this issue Mar 25, 2020
@evolverine
Stvad#46 going back to original directory structure until a discussio…
2ddca66 
…n with author renders it safe to change
evolverine added a commit to evolverine/CrowdAnki that referenced this issue Mar 25, 2020
@evolverine
Stvad#46 going back to original directory structure until a discussio…
5467e86 
…n with author renders it safe to change
evolverine added a commit to evolverine/CrowdAnki that referenced this issue Apr 2, 2020
@evolverine
Stvad#46 applying some of the changes suggested in the pull request
713b48a
evolverine added a commit to evolverine/CrowdAnki that referenced this issue Apr 6, 2020
@evolverine
Stvad#46 making the git importer server-agnostic; any git repository …
9a1bb88 
…will do, even local ones
evolverine added a commit to evolverine/CrowdAnki that referenced this issue Apr 6, 2020
@evolverine
Stvad#46 cloning the git repository in the configured snapshot directory
a26537d
evolverine added a commit to evolverine/CrowdAnki that referenced this issue Apr 18, 2020
@evolverine
Stvad#46 renamed a variable for clarity, and made it a Path instead o…
45446d5 
…f string
evolverine added a commit to evolverine/CrowdAnki that referenced this issue Apr 18, 2020
@evolverine
Stvad#46 extracted path manipulation into separate function
2a006e7
evolverine added a commit to evolverine/CrowdAnki that referenced this issue Apr 18, 2020
@evolverine
Stvad#46 extracted repository cloning into separate function
493c15b
evolverine added a commit to evolverine/CrowdAnki that referenced this issue Apr 18, 2020
@evolverine
Stvad#46 showing an error message when the git repository is not foun…
86486ff 
…d at the provided URL
evolverine added a commit to evolverine/CrowdAnki that referenced this issue Apr 18, 2020
@evolverine
Stvad#46 making the dependency more specific - instead of window, usi…
187afaf 
…ng profile_manager
evolverine added a commit to evolverine/CrowdAnki that referenced this issue May 12, 2020
@evolverine
Stvad#46 passing in only the profile manager, instead of the window o…
71ac55f 
…bject
evolverine added a commit to evolverine/CrowdAnki that referenced this issue May 12, 2020
@evolverine
Stvad#46 fixed a bug where a URL containing '/' at the end would resu…
c191b7c 
…lt in the repository being instantiated without a parent folder
evolverine added a commit to evolverine/CrowdAnki that referenced this issue May 18, 2020
@evolverine
Stvad#46 urlparse wasn't helping, because github don't have query par…
e007183 
…ameters. Also, checking for the space wasn't useful either; in that case, Dulwich will report an error

Signed-off-by: Mihai Chira <mihai.chira@gmail.com>
Stvad added a commit that referenced this issue May 25, 2020
@Stvad
Merge pull request #78 from evolverine/46_git_import
a42041f 
#46 git import
@Stvad Stvad closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement git history import
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stvad @evolverine