Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping the babel-plugin-styled-components to 2.0.5 make a regression in performance inside our tests #373

Closed
daniloab opened this issue Feb 24, 2022 · 6 comments

Comments

@daniloab
Copy link

daniloab commented Feb 24, 2022

Bumping the babel-plugin-styled-components to the last version 2.0.5 makes the performance from our tests decrease a lot making a unique test take at least 8 minutes to run and breaking it.

By now, our fix was reverted to the previous version 2.0.4 and our tests start to run normally again.

before bump
Screen Shot 2022-02-24 at 14 33 59

after bump
Screen Shot 2022-02-24 at 14 33 37

reverting bump
Screen Shot 2022-02-24 at 14 37 54

@janicduplessis
Copy link

I'm also seeing a major perf regression of my website build after bumping to 2.0.5, 2.0.4 is fine. At runtime I also get a _styled is not defined error. From inspecting the code it seems like the styled component import is not added automatically.

@ghost
Copy link

ghost commented Feb 24, 2022

I have the same problem here, but with the NextJS build.
It used to be 3 minutes (with 2.0.3) and now it takes over 20 minutes (2.0.5).

@jordan-brough
Copy link

We're seeing build times increase so much that automated builds are timing out if we try to update from 2.0.3 to 2.0.5.

@quantizor
Copy link
Collaborator

Thank you, I'm going to revert the last change. Is 2.0.4 as bad or just 2.0.5?

@quantizor
Copy link
Collaborator

@jordan-brough
Copy link

Thanks. v2.0.6 seems to have fixed the issues we were seeing. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants