Skip to content

Commit

Permalink
fix(modularScale): Remove rem/em restriction
Browse files Browse the repository at this point in the history
Remove rem/em restriction from modularScale
  • Loading branch information
bhough committed May 5, 2019
1 parent a7b8f53 commit 70f373e
Show file tree
Hide file tree
Showing 47 changed files with 1,262 additions and 1,313 deletions.
12 changes: 6 additions & 6 deletions docs/assets/polished.js
Original file line number Diff line number Diff line change
Expand Up @@ -891,7 +891,7 @@
}

if (ratio === void 0) {
ratio = 'perfectFourth';
ratio = 1.333;
}

if (typeof steps !== 'number') {
Expand All @@ -908,7 +908,7 @@

var realRatio = typeof ratio === 'string' ? getRatio(ratio) : ratio;

if (typeof realBase === 'string' || unit !== 'em' && unit !== 'rem') {
if (typeof realBase === 'string') {
throw new PolishedError(44, base);
}

Expand Down Expand Up @@ -2210,10 +2210,10 @@
var hexRgbaRegex = /^#[a-fA-F0-9]{8}$/;
var reducedHexRegex = /^#[a-fA-F0-9]{3}$/;
var reducedRgbaHexRegex = /^#[a-fA-F0-9]{4}$/;
var rgbRegex = /^rgb\(\s*(\d{1,3})\s*,\s*(\d{1,3})\s*,\s*(\d{1,3})\s*\)$/;
var rgbaRegex = /^rgba\(\s*(\d{1,3})\s*,\s*(\d{1,3})\s*,\s*(\d{1,3})\s*,\s*([-+]?[0-9]*[.]?[0-9]+)\s*\)$/;
var hslRegex = /^hsl\(\s*(\d{0,3}[.]?[0-9]+)\s*,\s*(\d{1,3})%\s*,\s*(\d{1,3})%\s*\)$/;
var hslaRegex = /^hsla\(\s*(\d{0,3}[.]?[0-9]+)\s*,\s*(\d{1,3})%\s*,\s*(\d{1,3})%\s*,\s*([-+]?[0-9]*[.]?[0-9]+)\s*\)$/;
var rgbRegex = /^rgb\(\s*(\d{1,3})\s*,\s*(\d{1,3})\s*,\s*(\d{1,3})\s*\)$/i;
var rgbaRegex = /^rgba\(\s*(\d{1,3})\s*,\s*(\d{1,3})\s*,\s*(\d{1,3})\s*,\s*([-+]?[0-9]*[.]?[0-9]+)\s*\)$/i;
var hslRegex = /^hsl\(\s*(\d{0,3}[.]?[0-9]+)\s*,\s*(\d{1,3})%\s*,\s*(\d{1,3})%\s*\)$/i;
var hslaRegex = /^hsla\(\s*(\d{0,3}[.]?[0-9]+)\s*,\s*(\d{1,3})%\s*,\s*(\d{1,3})%\s*,\s*([-+]?[0-9]*[.]?[0-9]+)\s*\)$/i;
/**
* Returns an RgbColor or RgbaColor object. This utility function is only useful
* if want to extract a color component. With the color util `toColorString` you
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -8479,7 +8479,7 @@ <h3 class='fl m0' id='modularscale'>
<div class='space-bottom0'>
<div>
<span class='code bold'>ratio</span> <code class='quiet'>(<a href="#modularscaleratio">ModularScaleRatio</a>
= <code>&#39;perfectFourth&#39;</code>)</code>
= <code>1.333</code>)</code>

</div>

Expand Down
4 changes: 2 additions & 2 deletions flow-typed/npm/@babel/cli_vx.x.x.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// flow-typed signature: 4ad356c49010284bb9c6b4c9eb0dd6e5
// flow-typed version: <<STUB>>/@babel/cli_v^7.0.0/flow_v0.79.1
// flow-typed signature: 075f8105d56e7ff56843b0a0aaec48b5
// flow-typed version: <<STUB>>/@babel/cli_v^7.4.4/flow_v0.98.0

/**
* This is an autogenerated libdef stub for:
Expand Down
11 changes: 2 additions & 9 deletions flow-typed/npm/@babel/core_vx.x.x.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// flow-typed signature: 7e61f2f14e63a633a1634c50153c3c30
// flow-typed version: <<STUB>>/@babel/core_v^7.0.0/flow_v0.79.1
// flow-typed signature: c4c9a68ebcd82703d0bfedd66e1db1ff
// flow-typed version: <<STUB>>/@babel/core_v^7.4.4/flow_v0.98.0

/**
* This is an autogenerated libdef stub for:
Expand Down Expand Up @@ -134,10 +134,6 @@ declare module '@babel/core/lib/transform-file-browser' {
declare module.exports: any;
}

declare module '@babel/core/lib/transform-file-sync-browser' {
declare module.exports: any;
}

declare module '@babel/core/lib/transform-file' {
declare module.exports: any;
}
Expand Down Expand Up @@ -267,9 +263,6 @@ declare module '@babel/core/lib/transform-ast.js' {
declare module '@babel/core/lib/transform-file-browser.js' {
declare module.exports: $Exports<'@babel/core/lib/transform-file-browser'>;
}
declare module '@babel/core/lib/transform-file-sync-browser.js' {
declare module.exports: $Exports<'@babel/core/lib/transform-file-sync-browser'>;
}
declare module '@babel/core/lib/transform-file.js' {
declare module.exports: $Exports<'@babel/core/lib/transform-file'>;
}
Expand Down
24 changes: 19 additions & 5 deletions flow-typed/npm/@babel/plugin-transform-runtime_vx.x.x.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// flow-typed signature: 85444e87e5e4822c0f40fd1beaec0b6c
// flow-typed version: <<STUB>>/@babel/plugin-transform-runtime_v^7.0.0/flow_v0.79.1
// flow-typed signature: 0d3f49d66a9bb7cc136cfb644f0e4ae4
// flow-typed version: <<STUB>>/@babel/plugin-transform-runtime_v^7.4.4/flow_v0.98.0

/**
* This is an autogenerated libdef stub for:
Expand All @@ -22,18 +22,32 @@ declare module '@babel/plugin-transform-runtime' {
* require those files directly. Feel free to delete any files that aren't
* needed.
*/
declare module '@babel/plugin-transform-runtime/lib/definitions' {
declare module '@babel/plugin-transform-runtime/lib/helpers' {
declare module.exports: any;
}

declare module '@babel/plugin-transform-runtime/lib/index' {
declare module.exports: any;
}

declare module '@babel/plugin-transform-runtime/lib/runtime-corejs2-definitions' {
declare module.exports: any;
}

declare module '@babel/plugin-transform-runtime/lib/runtime-corejs3-definitions' {
declare module.exports: any;
}

// Filename aliases
declare module '@babel/plugin-transform-runtime/lib/definitions.js' {
declare module.exports: $Exports<'@babel/plugin-transform-runtime/lib/definitions'>;
declare module '@babel/plugin-transform-runtime/lib/helpers.js' {
declare module.exports: $Exports<'@babel/plugin-transform-runtime/lib/helpers'>;
}
declare module '@babel/plugin-transform-runtime/lib/index.js' {
declare module.exports: $Exports<'@babel/plugin-transform-runtime/lib/index'>;
}
declare module '@babel/plugin-transform-runtime/lib/runtime-corejs2-definitions.js' {
declare module.exports: $Exports<'@babel/plugin-transform-runtime/lib/runtime-corejs2-definitions'>;
}
declare module '@babel/plugin-transform-runtime/lib/runtime-corejs3-definitions.js' {
declare module.exports: $Exports<'@babel/plugin-transform-runtime/lib/runtime-corejs3-definitions'>;
}
110 changes: 83 additions & 27 deletions flow-typed/npm/@babel/preset-env_vx.x.x.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// flow-typed signature: abc7696ac5861e41369914924f804d0d
// flow-typed version: <<STUB>>/@babel/preset-env_v^7.0.0/flow_v0.79.1
// flow-typed signature: 6c318ac31baccac16c158aa01e50aeb6
// flow-typed version: <<STUB>>/@babel/preset-env_v^7.4.4/flow_v0.98.0

/**
* This is an autogenerated libdef stub for:
Expand All @@ -22,7 +22,11 @@ declare module '@babel/preset-env' {
* require those files directly. Feel free to delete any files that aren't
* needed.
*/
declare module '@babel/preset-env/data/built-in-features' {
declare module '@babel/preset-env/data/built-ins.json' {
declare module.exports: any;
}

declare module '@babel/preset-env/data/corejs2-built-in-features' {
declare module.exports: any;
}

Expand All @@ -42,19 +46,15 @@ declare module '@babel/preset-env/lib/available-plugins' {
declare module.exports: any;
}

declare module '@babel/preset-env/lib/built-in-definitions' {
declare module.exports: any;
}

declare module '@babel/preset-env/lib/debug' {
declare module.exports: any;
}

declare module '@babel/preset-env/lib/default-includes' {
declare module '@babel/preset-env/lib/filter-items' {
declare module.exports: any;
}

declare module '@babel/preset-env/lib/defaults' {
declare module '@babel/preset-env/lib/get-option-specific-excludes' {
declare module.exports: any;
}

Expand All @@ -74,15 +74,47 @@ declare module '@babel/preset-env/lib/options' {
declare module.exports: any;
}

declare module '@babel/preset-env/lib/targets-parser' {
declare module '@babel/preset-env/lib/polyfills/corejs2/built-in-definitions' {
declare module.exports: any;
}

declare module '@babel/preset-env/lib/polyfills/corejs2/entry-plugin' {
declare module.exports: any;
}

declare module '@babel/preset-env/lib/polyfills/corejs2/get-platform-specific-default' {
declare module.exports: any;
}

declare module '@babel/preset-env/lib/polyfills/corejs2/usage-plugin' {
declare module.exports: any;
}

declare module '@babel/preset-env/lib/polyfills/corejs3/built-in-definitions' {
declare module.exports: any;
}

declare module '@babel/preset-env/lib/polyfills/corejs3/entry-plugin' {
declare module.exports: any;
}

declare module '@babel/preset-env/lib/polyfills/corejs3/shipped-proposals' {
declare module.exports: any;
}

declare module '@babel/preset-env/lib/polyfills/corejs3/usage-plugin' {
declare module.exports: any;
}

declare module '@babel/preset-env/lib/polyfills/regenerator/entry-plugin' {
declare module.exports: any;
}

declare module '@babel/preset-env/lib/use-built-ins-entry-plugin' {
declare module '@babel/preset-env/lib/polyfills/regenerator/usage-plugin' {
declare module.exports: any;
}

declare module '@babel/preset-env/lib/use-built-ins-plugin' {
declare module '@babel/preset-env/lib/targets-parser' {
declare module.exports: any;
}

Expand All @@ -91,8 +123,11 @@ declare module '@babel/preset-env/lib/utils' {
}

// Filename aliases
declare module '@babel/preset-env/data/built-in-features.js' {
declare module.exports: $Exports<'@babel/preset-env/data/built-in-features'>;
declare module '@babel/preset-env/data/built-ins.json.js' {
declare module.exports: $Exports<'@babel/preset-env/data/built-ins.json'>;
}
declare module '@babel/preset-env/data/corejs2-built-in-features.js' {
declare module.exports: $Exports<'@babel/preset-env/data/corejs2-built-in-features'>;
}
declare module '@babel/preset-env/data/plugin-features.js' {
declare module.exports: $Exports<'@babel/preset-env/data/plugin-features'>;
Expand All @@ -106,17 +141,14 @@ declare module '@babel/preset-env/data/unreleased-labels.js' {
declare module '@babel/preset-env/lib/available-plugins.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/available-plugins'>;
}
declare module '@babel/preset-env/lib/built-in-definitions.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/built-in-definitions'>;
}
declare module '@babel/preset-env/lib/debug.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/debug'>;
}
declare module '@babel/preset-env/lib/default-includes.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/default-includes'>;
declare module '@babel/preset-env/lib/filter-items.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/filter-items'>;
}
declare module '@babel/preset-env/lib/defaults.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/defaults'>;
declare module '@babel/preset-env/lib/get-option-specific-excludes.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/get-option-specific-excludes'>;
}
declare module '@babel/preset-env/lib/index.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/index'>;
Expand All @@ -130,14 +162,38 @@ declare module '@babel/preset-env/lib/normalize-options.js' {
declare module '@babel/preset-env/lib/options.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/options'>;
}
declare module '@babel/preset-env/lib/targets-parser.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/targets-parser'>;
declare module '@babel/preset-env/lib/polyfills/corejs2/built-in-definitions.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/polyfills/corejs2/built-in-definitions'>;
}
declare module '@babel/preset-env/lib/polyfills/corejs2/entry-plugin.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/polyfills/corejs2/entry-plugin'>;
}
declare module '@babel/preset-env/lib/polyfills/corejs2/get-platform-specific-default.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/polyfills/corejs2/get-platform-specific-default'>;
}
declare module '@babel/preset-env/lib/polyfills/corejs2/usage-plugin.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/polyfills/corejs2/usage-plugin'>;
}
declare module '@babel/preset-env/lib/polyfills/corejs3/built-in-definitions.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/polyfills/corejs3/built-in-definitions'>;
}
declare module '@babel/preset-env/lib/polyfills/corejs3/entry-plugin.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/polyfills/corejs3/entry-plugin'>;
}
declare module '@babel/preset-env/lib/use-built-ins-entry-plugin.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/use-built-ins-entry-plugin'>;
declare module '@babel/preset-env/lib/polyfills/corejs3/shipped-proposals.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/polyfills/corejs3/shipped-proposals'>;
}
declare module '@babel/preset-env/lib/use-built-ins-plugin.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/use-built-ins-plugin'>;
declare module '@babel/preset-env/lib/polyfills/corejs3/usage-plugin.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/polyfills/corejs3/usage-plugin'>;
}
declare module '@babel/preset-env/lib/polyfills/regenerator/entry-plugin.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/polyfills/regenerator/entry-plugin'>;
}
declare module '@babel/preset-env/lib/polyfills/regenerator/usage-plugin.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/polyfills/regenerator/usage-plugin'>;
}
declare module '@babel/preset-env/lib/targets-parser.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/targets-parser'>;
}
declare module '@babel/preset-env/lib/utils.js' {
declare module.exports: $Exports<'@babel/preset-env/lib/utils'>;
Expand Down
4 changes: 2 additions & 2 deletions flow-typed/npm/@babel/preset-flow_vx.x.x.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// flow-typed signature: 8c2e35307edf5356bce3bdea015f3e0d
// flow-typed version: <<STUB>>/@babel/preset-flow_v^7.0.0/flow_v0.79.1
// flow-typed signature: 0f3b00d4cc4094e448c11074ee93d9ea
// flow-typed version: <<STUB>>/@babel/preset-flow_v^7.0.0/flow_v0.98.0

/**
* This is an autogenerated libdef stub for:
Expand Down

0 comments on commit 70f373e

Please sign in to comment.