-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Flow): Type definition improvements #222
Conversation
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 67 67
Lines 370 370
Branches 100 100
=====================================
Hits 370 370
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 68 68
Lines 388 386 -2
Branches 101 102 +1
=====================================
- Hits 388 386 -2
Continue to review full report at Codecov.
|
fc52ba9
to
64905f2
Compare
typeof color.red === 'number' && | ||
typeof color.green === 'number' && | ||
typeof color.blue === 'number' && | ||
// $FlowIgnoreNextLine not sure why this complains | ||
typeof color.alpha !== 'number' | ||
(typeof color.alpha !== 'number' || typeof color.alpha === 'undefined') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|| typeof color.alpha === 'undefined'
Does this just silence the Flow error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, though I'm still working my way through this file, as it is the sole one left keeping us from having full flow support. It is proving...troublesome.
0da8e2a
to
9829811
Compare
//$FlowFixMe
for zero config suppressions._statefulSelectors
-based modules./lib
to ignore in .flowconfig.Partially addresses #197