Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readableColor): add missing export of readableColor to index #231

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

igl
Copy link
Contributor

@igl igl commented Aug 18, 2017

the export of readableColor() is missing in the index.js

import { readableColor } from 'polished' does currently not work

@bhough bhough changed the title bug(color) add missing export of readableColor bug(color): add missing export of readableColor Aug 18, 2017
@bhough bhough changed the title bug(color): add missing export of readableColor fix(color): add missing export of readableColor Aug 18, 2017
@bhough bhough changed the title fix(color): add missing export of readableColor fix(readableColor): add missing export of readableColor to index Aug 18, 2017
@igl
Copy link
Contributor Author

igl commented Aug 18, 2017

That precommit hook does not work as intended either:

~/polished (master +) λ git commit -m "add missing export of readableColor"
husky > npm run -s precommit (node v6.11.2)

 ✔ Running tasks for src/**/!(*.test).js
 ↓ Running tasks for src/**/*.test.js [skipped]
   → No staged files match src/**/*.test.js
husky > npm run -s postcommit (node v6.11.2)

INVALID COMMIT MSG: does not match "<type>(<scope>): <subject>" !
add missing export of readableColor

husky > post-commit hook failed (add --no-verify to bypass)
[master 78550f4] add missing export of readableColor
 1 file changed, 2 insertions(+)
~/polished (master) λ git log -1 --pretty=%B
add missing export of readableColor

@bhough
Copy link
Contributor

bhough commented Aug 18, 2017

@igl Thanks for catching and fixing this. By the precommit hook not working, you mean that it isn't blocking the commit despite not meeting the format?

@codecov
Copy link

codecov bot commented Aug 18, 2017

Codecov Report

Merging #231 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #231   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          68     68           
  Lines         388    388           
  Branches      101    101           
=====================================
  Hits          388    388

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d4cce...3f376f1. Read the comment docs.

@bhough bhough merged commit b776076 into styled-components:master Aug 18, 2017
@igl
Copy link
Contributor Author

igl commented Aug 18, 2017

@bhough Yes

I did --amend and force pushed with the correct title now.

@igl igl deleted the missing-export branch August 18, 2017 15:46
@bhough
Copy link
Contributor

bhough commented Aug 18, 2017

@igl I will take a look at why that might be happening. Just tried on my side and it didn't create a commit, so will need to dig further. Thanks again for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants