-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] @font-face breaks styles #493
Comments
Thanks, will push a patch for this. |
patched upstream(parser), cc @mxstbr. |
Awesome 👍 |
@thysultan thank you for the very fast reply and fix! It works fine now. @k15a maybe this issue should be stay open until deps are updated to stylis@1.1.2+ ? ps: It took me awhile to understand that it was fixed by this commit ;-) |
@marc-rutkowski Ahh. I thought that we are using version ranges so the patches are covered. OFC it should stay open then^^ PRs are always great 👍 |
Version
2.0.0-3
Reproduction
https://github.com/marc-rutkowski/styled-components-v2-font-face
(standard create-react-app)
Steps to reproduce
Dev server starts and the app home page displays a red background and use the Pangolin webfont.
@font-face
is set by using theinjectGlobal
helper in App.jsNow, switch to styled-components v2 :
Expected Behavior
Same rendering than with styled-components v1.x
Actual Behavior
@font-face
breaks styling. The red background is not visible anymore and default font is used instead of the custom one.If the
@font-face
rule is removed the red background appears has before.Maybe related to #462 ?
ps: thanks for this great lib!
The text was updated successfully, but these errors were encountered: