Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

false positive 'selector-nest-combinators' #306

Closed
Cole-Beckwith-SP opened this issue Jan 31, 2019 · 4 comments
Closed

false positive 'selector-nest-combinators' #306

Cole-Beckwith-SP opened this issue Jan 31, 2019 · 4 comments
Labels
Bug 🐛 Something isn't working PR made 🚀 A Pull Request has been created.

Comments

@Cole-Beckwith-SP
Copy link

Given a value 'always' and a stylesheet:

.class-name {
	#{if(&, "&", "")} {

	}	
}

The linter will report the error:

'Expected combinator "}" of type "tag" to be in a nested form'
@kristerkari kristerkari added the Bug 🐛 Something isn't working label Jan 31, 2019
@kristerkari
Copy link
Collaborator

Thanks! Looks like the rule needs to ignore interpolation.

@Cole-Beckwith-SP
Copy link
Author

Thanks for this project!

@kristerkari
Copy link
Collaborator

Thanks for reporting the issue :)

I already have fix for the issue, so I'll try to release a patch tonight or tomorrow.

@kristerkari kristerkari mentioned this issue Feb 1, 2019
Merged
@kristerkari kristerkari added the PR made 🚀 A Pull Request has been created. label Feb 1, 2019
@kristerkari
Copy link
Collaborator

fix released in v3.5.2
https://github.com/kristerkari/stylelint-scss/releases/tag/3.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐛 Something isn't working PR made 🚀 A Pull Request has been created.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kristerkari @Cole-Beckwith-SP