Rename rules to use inclusive language #958
Conversation
As well as using inclusive language, this change aligns with similar improvements made in Stylelint: https://stylelint.io/CHANGELOG#1370. - `at-import-partial-extension-whitelist` -> `at-import-partial-extension-allowed-list` - `at-import-partial-extension-blacklist` -> `at-import-partial-extension-disallowed-list` Resolves stylelint-scss#571
|
Thanks @01taylop ! The changes look otherwise good, but the problem is that renaming a rule is a breaking change. Instead of just renaming a rule, the correct way would be to first deprecate the rule and add the same rule with the new name to a minor release to give people time to migrate to the new name. Then after some time the old rules could be removed in a major release. |
|
There's actually a quite "recent" example of deprecating a rule in this repo: #867 |
|
Thank you for the feedback @kristerkari ! I will checkout that PR and make the necessary changes to re-introduce the existing rules with a deprecation notice. At least it was good to review the changes required to rename the rules :) |
|
@kristerkari Just got back from a long-haul flight, but I think this iteration is what you hoping for? |
|
Thanks! I'll try to get this re-review this weekend 👍 |
|
Sorry for the delay, but I'll review this tonight 👍 |
As well as using inclusive language, this change aligns with similar improvements made in Stylelint: https://stylelint.io/CHANGELOG#1370.
at-import-partial-extension-whitelist->at-import-partial-extension-allowed-listat-import-partial-extension-blacklist->at-import-partial-extension-disallowed-listResolves #571