Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value-keyword-case #133

Closed
compeek opened this issue Oct 23, 2019 · 2 comments · Fixed by #136
Closed

Add value-keyword-case #133

compeek opened this issue Oct 23, 2019 · 2 comments · Fixed by #136

Comments

@compeek
Copy link

compeek commented Oct 23, 2019

Clearly describe the bug

It seems to me that value-keyword-case is probably missing in stylelint-config-standard. It is not called out in the readme as not included, and all of the other *-case options are included and set to lower.

Which rule, if any, is the bug related to?

value-keyword-case

What CSS is needed to reproduce the bug?

What stylelint configuration is needed to reproduce the bug?

Which version of stylelint are you using?

How are you running stylelint: CLI, PostCSS plugin, Node.js API?

Does the bug relate to non-standard syntax (e.g. SCSS, Less etc.)?

What did you expect to happen?

I expect value-keyword-case to be included in stylelint-config-standard for consistency.

What actually happened (e.g. what warnings or errors did you get)?

value-keyword-case is not included in stylelint-config-standard.

@compeek compeek changed the title Missing value-keyword-case? value-keyword-case missing in stylelint-config-standard Oct 23, 2019
@compeek compeek changed the title value-keyword-case missing in stylelint-config-standard value-keyword-case possibly missing in stylelint-config-standard Oct 23, 2019
@compeek
Copy link
Author

compeek commented Oct 23, 2019

I will say that after messing around with this more in my project, I realized a potential reason this rule isn't included in stylelint-config-standard: font family names are usually not lowercase, but they would fall under this rule.

I'll leave the issue open in case this is worth considering nonetheless.

@hudochenkov hudochenkov transferred this issue from stylelint/stylelint Oct 23, 2019
@jeddy3 jeddy3 changed the title value-keyword-case possibly missing in stylelint-config-standard Add value-keyword-case Jan 11, 2020
@jeddy3 jeddy3 added the type: enhancement a new feature that isn't related to rules label Jan 11, 2020
@jeddy3
Copy link
Member

jeddy3 commented Jan 11, 2020

@compeek Thanks for raising the issue.

It seems to me that value-keyword-case is probably missing

I agree. It's probably an oversight that it wasn't included.

font family names are usually not lowercase, but they would fall under this rule.

The rule ignores <custom-idents> of known properties. There are tests covering font-family names. So, I can't think of a reason off-hand not to include the rule.


I'm happy to see this rule be included in the config unless there are any objections?

@jeddy3 jeddy3 added status: discussion and removed type: enhancement a new feature that isn't related to rules labels Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants