Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support for browserslist file #2068

Closed
npars opened this issue Nov 17, 2016 · 2 comments
Closed

Feature Request: Support for browserslist file #2068

npars opened this issue Nov 17, 2016 · 2 comments
Labels
status: needs discussion triage needs further discussion

Comments

@npars
Copy link

npars commented Nov 17, 2016

Some rules support passing a browserslist string as an argument. Other browserslist utilities (autoprefixer) support a browserslist file in the current or parent directories. It would be useful for styelint to support this file as well so that the browserslist configuration does not need to be duplicated in many places.

This applies to:
no-browser-hacks, no-unsupported-browser-features

@ntwb ntwb added the status: needs discussion triage needs further discussion label Nov 18, 2016
@jeddy3
Copy link
Member

jeddy3 commented Nov 19, 2016

@npars Thank you for the suggestion. As with #2054 (comment), I think your issue could be the catalyst for discussing whether these rules belong outside of core as plugins (perhaps within the same pack as they are both focused on checking things specific to the browsers being targetted). As with #2054, I think doing so would be a good thing. For example, it could facilitate experimentation with such a browserlist feature.

@stylelint/core I think we've a better understanding of the division of core rules and plugins now than we had 6 months ago. And I think 8.0.0 is shaping up as our opportunity to further stabilise core, ensuring that all the rules within it adhere to our criteria. What do you think?

As a reminder, both these rules (along with no-indistinguishable-colors, which seems mostly applicable to compiled CSS) are wrappers around 3rd party PostCSS plugins.

@jeddy3
Copy link
Member

jeddy3 commented Nov 26, 2016

Closing in favour of #2079

@jeddy3 jeddy3 closed this as completed Nov 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs discussion triage needs further discussion
Development

No branches or pull requests

3 participants