-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added milestones and issue search links to the issue template #2258
Added milestones and issue search links to the issue template #2258
Conversation
I'm not sure this is necessary. That means part of the issue template will have to change as we do future releases. We could add a note that you should search through issues and pull requests in the repo to see if your concern has come up before — everybody should always do that for any repo before submitting an issue. |
@davidtheclark I think that's a fair assumption, but in the case of v8, it doesn't have an official release date so I could see this one line hanging out for a little bit. Obviously I'm speculating on how far out the release might be. In this case, the master changelog doesn't show anything related to this bug fix (which makes sense as it's not in any current releases). I had no idea that there was a v8 release coming out either. Of course it's my fault for not digging through the closed PRs/issues or checking the other branches, but I think that for the cases where you have other people who are lazy like me, this could help prevent the bug being from being filed. If I'm the only one who is too lazy to keep digging, then you're probably right that this isn't required at all. |
Also a fair point but I would argue that all the things that are listed under "Here are the best ways to help resolve your issue:" are things that we should always be mindful of when contributing/opening an issue on a repo. The point of a template and little reminder notes like that are because we know that without them, popular repos will have a lot of incoming duplicate or one-liner bug reports without steps to reproduce. I don't see the harm in adding a helpful reminder like you describe as it's a win/win for all but obviously this is your call! |
How about a note about checking if the issue is resolved in an upcoming major milestone? e.g. <!--
Before posting, please check that your issue:
1. Hasn't already been resolved in:
- the next release (https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md)
- an upcoming major milestone (https://github.com/stylelint/stylelint/milestones)
2. Hasn't already been discussed (https://github.com/stylelint/stylelint/search)
-->
<!--
Here are the best ways to help resolve your issue:
1. Figure out what needs to be done, propose it, and then write the code and submit a PR.
2. If your issue is a bug, consider at least submitting a PR with failing tests.
--> This means we won't need to update the issue after each release, and I think it also addresses @hankthewhale concerns I've updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, @jeddy3's idea seems good.
This all sounds good to me. I'll make the update today. |
@davidtheclark @jeddy3 alright fellas. Made the requested changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hankthewhale Thanks very much :) @davidtheclark Can you merge after your review please? |
Changed the PR description to match what's actually happening now. |
…int#2258) * Added link to v8 changelog in the issue template * add milestone and search links to issue template
#2256
I didn't check the v8 changelog before creating a duplicate bug report. Having this message in the issue template could help prevent myself and others from doing that in the future.