Use HTTPS links where applicable. #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudochenkov
requested changes
Feb 1, 2017
| @@ -1,6 +1,6 @@ | |||
| # no-invalid-double-slash-comments | |||
|
|
|||
| Disallow double-slash comments (`//...`) which are not supported by CSS and [could lead to unexpected results](http://stackoverflow.com/a/20192639/130652). | |||
| Disallow double-slash comments (`//...`) which are not supported by CSS and [could lead to unexpected results](https://stackoverflow.com/a/20192639/130652). | |||
There was a problem hiding this comment.
Funny thing: it redirects to HTTP. Shall we use the final URL instead? https://stackoverflow.com/questions/12298890/is-it-bad-practice-to-comment-out-single-lines-of-css-with/20192639#20192639
There was a problem hiding this comment.
Ha, it does to, I use the HTTPS Everywhere Chrome extension from EFF.
And for me, it remains on the HTTPS site, so either or I guess
I've a preference to make as many as possible links used HTTPS
jeddy3
approved these changes
Feb 1, 2017
|
LGTM |
davidtheclark
approved these changes
Feb 1, 2017
sergesemashko
pushed a commit
to sergesemashko/stylelint
that referenced
this pull request
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe also a future a beginner-friendly PR could be accepted that updates our code examples to prefer when possible the use of
https://in our code examples.