Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreProperties: [] to value-keyword-case #2424

Closed
oleksiibilous opened this issue Mar 14, 2017 · 4 comments
Closed

Add ignoreProperties: [] to value-keyword-case #2424

oleksiibilous opened this issue Mar 14, 2017 · 4 comments
Labels
good first issue is good for newcomers status: wip is being worked on by someone type: new option a new option for an existing rule

Comments

@oleksiibilous
Copy link

oleksiibilous commented Mar 14, 2017

Describe the issue. Is it a bug or a feature request (new rule, new option, etc.)?

"A feature request"

Which rule, if any, is this issue related to?

value-keyword-case

What CSS is needed to reproduce this issue?

.elementWithCamelCaseName {}

.element {
  composes: elementWithCamelCaseName;
}

What stylelint configuration is needed to reproduce this issue?

{
  "rules": {
    "value-keyword-case": "lower",
    }
  }
}

Which version of stylelint are you using?

6.7.1

How are you running stylelint: CLI, PostCSS plugin, Node API?

"WebpackPluginStylelint"

Does your issue relate to non-standard syntax (e.g. SCSS, nesting, etc.)?

"Yes, it's related to CSS modules"

What did you expect to happen?

"No warnings to be flagged for composes property"

What actually happened (e.g. what warnings or errors you are getting)?

"The following warnings were flagged: Expected camelCaseName to be lowecasename"

Maybe it is a good idea to add additional option to this rule? Something like ignoreProperties? I can work on PR if anyone is interested. Thank you

@alexander-akait
Copy link
Member

@oleksiibilous thanks for feedback, be right ignore composes property by default, because it is always custom-ident, PR 👍

@alexander-akait alexander-akait added good first issue is good for newcomers status: ready to implement is ready to be worked on by someone type: bug a problem with a feature or rule labels Mar 14, 2017
@jeddy3
Copy link
Member

jeddy3 commented Mar 19, 2017

be right ignore composes property by default,

Let's not add code to core for methodologies. That's what the ignore* options are for.

Something like ignoreProperties?

Yes, that would be perfect. @oleksiibilous Feel free to contribute this option via a PR.

@jeddy3 jeddy3 added type: new option a new option for an existing rule and removed type: bug a problem with a feature or rule labels Mar 19, 2017
@jeddy3 jeddy3 changed the title value-keyword-case ignore properties Add ignoreProperties: [] option to value-keyword-case Mar 19, 2017
@oleksiibilous
Copy link
Author

ignoreProperties sounds good👍 Will work on it

@jeddy3 jeddy3 changed the title Add ignoreProperties: [] option to value-keyword-case Add ignoreProperties: [] to value-keyword-case Sep 9, 2017
@jeddy3 jeddy3 added status: wip is being worked on by someone and removed status: ready to implement is ready to be worked on by someone labels Oct 3, 2017
@ntwb ntwb removed the Hacktoberfest label Nov 4, 2017
@CAYdenberg
Copy link
Contributor

@stylelint/core Should this issue be closed? It looks like it was fixed in #2937 ?

@jeddy3 jeddy3 closed this as completed Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue is good for newcomers status: wip is being worked on by someone type: new option a new option for an existing rule
Development

No branches or pull requests

5 participants