Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declaration-empty-line-before doesn't ignores shared-line comments #2847

Closed
andrey-gordeev opened this issue Sep 3, 2017 · 1 comment
Closed

Comments

@andrey-gordeev
Copy link

Describe the issue. Is it a bug or a feature request (new rule, new option, etc.)?

Now, declaration-empty-line-before doesn't ignores shared-line comments if it's in a selector. Probably relates to #2237.

Which rule, if any, is this issue related to?

declaration-empty-line-before
except: ["after-declaration", "first-nested"]
ignore: ["after-comment']

What CSS is needed to reproduce this issue?

.class { /* comment */
    display: block;
}

What stylelint configuration is needed to reproduce this issue?

e.g.

{
  "declaration-empty-line-before": ["always", {
      except: [
          "after-declaration",
          "first-nested"
      ],
      ignore: [
          "after-comment"
      ]
  }]
}

Which version of stylelint are you using?

8.0.0

How are you running stylelint: CLI, PostCSS plugin, Node API?

CLI

Does your issue relate to non-standard syntax (e.g. SCSS, nesting, etc.)?

No.

What did you expect to happen?

No warnings to be flagged.

What actually happened (e.g. what warnings or errors you are getting)?

The following warnings were flagged:

48:9   ✖  Expected empty line before declaration   declaration-empty-line-before
@jeddy3
Copy link
Member

jeddy3 commented Sep 4, 2017

@agordeev-zz Thanks for using the template. This should be fixed in the upcoming 8.1.0 release.

@jeddy3 jeddy3 closed this as completed Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants