Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error with trailing commas #3053

Closed
Mottie opened this issue Dec 6, 2017 · 1 comment
Closed

No error with trailing commas #3053

Mottie opened this issue Dec 6, 2017 · 1 comment

Comments

@Mottie
Copy link

Mottie commented Dec 6, 2017

Describe the issue. Is it a bug or a feature request (new rule, new option, etc.)?

Trailing commas should show as an error... new rule needed?

Which rule, if any, is this issue related to?

Not sure, but the no-descending-specificity rule was mentioned in #1156 (comment)

What CSS is needed to reproduce this issue?

If the follow css is entered into the Stylelint demo

body, {
  color: red !important;
}

What stylelint configuration is needed to reproduce this issue?

Default rules set in the demo - https://stylelint.io/demo/

Which version of stylelint are you using?

Newest

How are you running stylelint: CLI, PostCSS plugin, Node API?

Demo site

Does your issue relate to non-standard syntax (e.g. SCSS, nesting, etc.)?

Standard syntax. It's just not valid standard syntax because of a trailing comma.

What did you expect to happen?

Big red flashing lights. Panic in the streets.

What actually happened (e.g. what warnings or errors you are getting)?

Nothing

@hudochenkov
Copy link
Member

Thanks for the report and for using the template.

We had selector-no-empty for few releases, but then deprecated it. This is the reason: #2047 (comment).

Also from changelog:

  • It is beyond the scope of stylelint's core package to effectively validate against the CSS spec. Please investigate csstree and css-values for this functionality, and contribute to those projects and to stylelint plugins wrapping them. csstree already has a stylelint plugin, and css-values needs one to be developed. The following rules are deprecated for this reason.
    • media-feature-no-missing-punctuation.
    • selector-no-empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants