Add tests for parent directory files input

[regseb]

Hello,

Since stylelint 9.2.0, path with ".." (parent directory) are ignored ; like this example :

const config = {
    "rules": { "color-hex-case": "upper" }
};
stylelint.lint({ "files": "../style.css", config }).then(...);

To reproduce the problem, download attach file testcase.tar.gz and execute command :

tar zxvf testcase.tar.gz
cd testcase/folder
npm install
./testcase.js

Output on stylelint 9.2.0 :

../style.css { errored: false, output: '[]', results: [] }
style.css { errored: true,
output: '[{"source":"/home/regseb/dev/testcase/folder/style.css","deprecations":[],"invalidOptionWarnings":[],"parseErrors":[],"errored":true,"warnings":[{"line":2,"column":12,"rule":"color-hex-case","severity":"error","text":"Expected \"#ffffff\" to be \"#FFFFFF\" (color-hex-case)"}]}]',
results:
[ { source: '/home/regseb/dev/testcase/folder/style.css',
deprecations: [],
invalidOptionWarnings: [],
parseErrors: [],
errored: true,
warnings: [Array],
ignored: undefined,
_postcssResult: [Result] } ] }

Output on stylelint 9.1.3 :

style.css { errored: true,
output: '[{"source":"/home/regseb/dev/testcase/folder/style.css","deprecations":[],"invalidOptionWarnings":[],"parseErrors":[],"errored":true,"warnings":[{"line":2,"column":12,"rule":"color-hex-case","severity":"error","text":"Expected \"#ffffff\" to be \"#FFFFFF\" (color-hex-case)"}]}]',
results:
[ { source: '/home/regseb/dev/testcase/folder/style.css',
deprecations: [],
invalidOptionWarnings: [],
parseErrors: [],
errored: true,
warnings: [Array],
ignored: undefined,
_postcssResult: [Result] } ] }
../style.css { errored: true,
output: '[{"source":"/home/regseb/dev/testcase/style.css","deprecations":[],"invalidOptionWarnings":[],"parseErrors":[],"errored":true,"warnings":[{"line":2,"column":12,"rule":"color-hex-case","severity":"error","text":"Expected \"#ffffff\" to be \"#FFFFFF\" (color-hex-case)"}]}]',
results:
[ { source: '/home/regseb/dev/testcase/style.css',
deprecations: [],
invalidOptionWarnings: [],
parseErrors: [],
errored: true,
warnings: [Array],
ignored: undefined,
_postcssResult: [Result] } ] }

[hudochenkov]

Thanks for the report and for providing a test case.

Indeed, there is a regression. I don't know what caused it. It requires further investigation.

[ntwb]

After some sleuthing with git bisect the cause is commit 7208a87, your testcase works perfectly up unitl that commit @regseb

That commit turns out to be an update to globby to version 8.0.0 in #3167, now I just need to deermine if it was caused by stylelint or a globby regression.

p.s. Thanks a bunch for the testcase @regseb, extremely helpful 😄

[ntwb]

That was quick, indeed it's a globby issue sindresorhus/globby#80, they are waiting for an upstream fix before they can release, I've subscribed to the upstream issues and as soon as its resolved I'll test again, due to semantic versioning fingers crossed an npm update will resolve the issue once resolved upstream.

We will also release a patch version of stylelint anyways just to be sure, this might affect more stylelint users though are unaware as the issue is not causing "more" errors and warnings, it's causing less so they might not be being detected at all.

[mrmlnc]

Must be fixed by fast-glob@2.2.1. Please try to reinstall dependencies with npm i --force or npm i globby --force.

[ntwb]

@mrmlnc Thanks for updating fast-glob` and thanks for the update here :)

@regseb Could you test this out please and let me know how it goes, we can create a new stylelint release if need be but I think npm update should cover this, if not try the suggestion above from @mrmlnc to force the update

[regseb]

I test with npm update : stylelint 9.2.0, globby 8.0.1 and fast-glob 2.2.1. The test case and the real case work.

Thanks.

[ntwb]

Thanks @regseb, I'm going to reopen this issue so that we can add some tests to detect this issue in the future, that way if it happens again we'll be notified before, rather than after 😄