Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ignoreFiles configuration object property to be extendable #4501

Closed
Airkro opened this issue Dec 31, 2019 · 3 comments
Closed

Change ignoreFiles configuration object property to be extendable #4501

Airkro opened this issue Dec 31, 2019 · 3 comments
Labels
status: ready to implement is ready to be worked on by someone type: enhancement a new feature that isn't related to rules

Comments

@Airkro
Copy link
Contributor

Airkro commented Dec 31, 2019 •
edited

What is the problem you're trying to solve?

Share ignoreFiles in my config.

What solution would you like to see?

Make ignoreFiles extendable like eslint@7
@hudochenkov
Copy link
Member

Could you provide use case for this, please?

@Airkro
Copy link
Contributor Author

Airkro commented Jan 10, 2020 •
edited

options.ignorePatterns of eslint can be shareable by options.extends.

https://eslint.org/docs/user-guide/configuring#ignorepatterns-in-config-files

But stylelint will ignore that.

https://github.com/stylelint/stylelint/blob/master/lib/augmentConfig.js#L55

The ignoreFiles property is stripped from extended configs: only the root-level config can ignore files. -- https://stylelint.io/user-guide/configuration#ignorefiles

@hudochenkov hudochenkov added the status: needs discussion triage needs further discussion label Jan 10, 2020
@jeddy3
Copy link
Member

jeddy3 commented Jan 11, 2020

SGTM.

@jeddy3 jeddy3 changed the title Make ignoreFiles extendable like eslint@6 Change ignoreFiles configuration object property to be extendable Jan 11, 2020
@jeddy3 jeddy3 added status: ready to implement is ready to be worked on by someone type: enhancement a new feature that isn't related to rules and removed status: needs discussion triage needs further discussion labels Jan 11, 2020
@jeddy3 jeddy3 added this to the future-major milestone Jan 11, 2020
@jeddy3 jeddy3 removed this from the future-major milestone May 11, 2021
@Airkro Airkro mentioned this issue Jun 24, 2021
Closed
30 tasks
@Airkro Airkro mentioned this issue Oct 15, 2021
Merged
@Airkro Airkro closed this as completed Oct 22, 2021
@astorije astorije mentioned this issue Jun 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: ready to implement is ready to be worked on by someone type: enhancement a new feature that isn't related to rules
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hudochenkov @jeddy3 @Airkro